Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-2060

Trace bug in NettyServerCnxnFactory

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.4.6, 3.5.0
    • 3.4.7, 3.5.1, 3.6.0
    • server
    • None

    Description

      In NettyServerCnxnFactory, high throughput triggers a deadlock.

      This is caused by a channel-buffer-dumping debug statement in NettyServerCnxnFactory.java that is executed regardless of log level.

      This code path only executes when the server is throttling, but when it does it encounters a race and occasional deadlock between the channel buffer and NettyServerCnxn (jstack attached).

      The proposed fix adds the debug logging guard to this statement, similar to other existing statements.

      Attachments

        1. ZOOKEEPER-2060_deadlock_jstack.txt
          48 kB
          Ian Dimayuga
        2. ZOOKEEPER-2060.patch
          1 kB
          Ian Dimayuga
        3. ZOOKEEPER-2060.patch
          1 kB
          Ian Dimayuga

        Activity

          People

            iandi Ian Dimayuga
            iandi Ian Dimayuga
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified