Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.5.0
    • Fix Version/s: 3.4.7, 3.5.1, 3.6.0
    • Component/s: server
    • Labels:
      None

      Description

      Server has many critical threads running and co-ordinating each other like RequestProcessor chains et. When going through each threads, most of them having the similar structure like:

      public void run() {
              try {
                    while(running)
                         // processing logic
                    }
              } catch (InterruptedException e) {
                  LOG.error("Unexpected interruption", e);
              } catch (Exception e) {
                  LOG.error("Unexpected exception", e);
              }
              LOG.info("...exited loop!");
      }
      

      From the design I could see, there could be a chance of silently leaving the thread by swallowing the exception. If this happens in the production, the server would get hanged forever and would not be able to deliver its role. Now its hard for the management tool to detect this.

      The idea of this JIRA is to discuss and imprv.

      Reference: Community discussion thread

      1. ZOOKEEPER-1907.patch
        19 kB
        Rakesh R
      2. ZOOKEEPER-1907.patch
        20 kB
        Rakesh R
      3. ZOOKEEPER-1907.patch
        19 kB
        Rakesh R
      4. ZOOKEEPER-1907.patch
        23 kB
        Rakesh R
      5. ZOOKEEPER-1907.patch
        24 kB
        Rakesh R
      6. ZOOKEEPER-1907.patch
        24 kB
        Rakesh R
      7. ZOOKEEPER-1907.patch
        28 kB
        Rakesh R
      8. ZOOKEEPER-1907.patch
        35 kB
        Rakesh R
      9. ZOOKEEPER-1907.patch
        38 kB
        Rakesh R
      10. ZOOKEEPER-1907.patch
        39 kB
        Rakesh R
      11. ZOOKEEPER-1907.patch
        33 kB
        Rakesh R
      12. ZOOKEEPER-1907.patch
        35 kB
        Rakesh R
      13. ZOOKEEPER-1907.patch
        34 kB
        Rakesh R
      14. ZOOKEEPER-1907-br-3-4.patch
        23 kB
        Rakesh R

        Issue Links

          Activity

          Hongchao Deng made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Rakesh R made changes -
          Fix Version/s 3.4.7 [ 12325149 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907-br-3-4.patch [ 12743488 ]
          Rakesh R made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Patrick Hunt made changes -
          Link This issue is related to ZOOKEEPER-602 [ ZOOKEEPER-602 ]
          Michi Mutsuzaki made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907.patch [ 12702875 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907.patch [ 12700086 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907.patch [ 12699605 ]
          Rakesh R made changes -
          Link This issue relates to ZOOKEEPER-2029 [ ZOOKEEPER-2029 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907.patch [ 12696797 ]
          Rakesh R made changes -
          Fix Version/s 3.6.0 [ 12326518 ]
          Rakesh R made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907.patch [ 12696120 ]
          Rakesh R made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907.patch [ 12666828 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907.zip [ 12666793 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907.zip [ 12666793 ]
          Patrick Hunt made changes -
          Fix Version/s 3.5.1 [ 12326786 ]
          Fix Version/s 3.5.0 [ 12316644 ]
          Rakesh R made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907.patch [ 12657546 ]
          Patrick Hunt made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Affects Version/s 3.5.0 [ 12316644 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907.patch [ 12657067 ]
          Rakesh R made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Fix Version/s 3.5.0 [ 12316644 ]
          Fix Version/s 3.6.0 [ 12326518 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907.patch [ 12656748 ]
          Rakesh R made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907.patch [ 12647124 ]
          Michi Mutsuzaki made changes -
          Link This issue is related to ZOOKEEPER-207 [ ZOOKEEPER-207 ]
          Michi Mutsuzaki made changes -
          Fix Version/s 3.6.0 [ 12326518 ]
          Fix Version/s 3.5.0 [ 12316644 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907.patch [ 12638002 ]
          Rakesh R made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Rakesh R made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Rakesh R made changes -
          Attachment ZOOKEEPER-1907.patch [ 12637862 ]
          Rakesh R made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Rakesh R made changes -
          Field Original Value New Value
          Attachment ZOOKEEPER-1907.patch [ 12637860 ]
          Rakesh R created issue -

            People

            • Assignee:
              Rakesh R
              Reporter:
              Rakesh R
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development