[ZOOKEEPER-1835] dynamic configuration file renaming fails on Windows

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 3.5.0
• Component/s: quorum

Environment

Windows 7 64-bit, Oracle Java 1.6.0_32-b05

Release Note

Patch described in this comment below:
https://issues.apache.org/jira/browse/ZOOKEEPER-1835?focusedCommentId=13848420&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13848420

• Assignee: Bruno Freudensprung
• Reporter: Bruno Freudensprung
• Created: 12/Dec/13 21:05
• Updated: 04/Jul/14 11:11
• Resolved: 04/Jul/14 02:25

Description

On Windows, reconfig fails to rename the tmp dynamic config file to the real dynamic config filename.
Javadoc of java.io.File.renameTo says the behavior is highly plateform dependent, so I guess this should not be a big surprise.
The problem occurs in src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java that could be modified like this:
+ curFile.delete();
if (!tmpFile.renameTo(curFile)) {
+ configFile.delete();
if (!tmpFile.renameTo(configFile)) {
As suggested by Alex in https://issues.apache.org/jira/browse/ZOOKEEPER-1691 (btw there is more information about my test scenario over there) it is a bit "scary" to delete the current configuration file.