Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5.0
    • Component/s: documentation
    • Labels:
      None

      Description

      This JIRA is for documenting the details of removing the watches

      1. ZOOKEEPER-1831.patch
        1 kB
        Rakesh R
      2. ZOOKEEPER-1831.patch
        1 kB
        Rakesh R

        Activity

        Rakesh R created issue -
        Rakesh R made changes -
        Field Original Value New Value
        Component/s java client [ 12312381 ]
        Component/s server [ 12312382 ]
        Rakesh R made changes -
        Component/s documentation [ 12312422 ]
        Component/s java client [ 12312381 ]
        Component/s server [ 12312382 ]
        Rakesh R made changes -
        Fix Version/s 3.5.0 [ 12316644 ]
        Rakesh R made changes -
        Attachment ZOOKEEPER-1831.patch [ 12627325 ]
        Hide
        Raul Gutierrez Segales added a comment -

        lgtm mostly - here are some small grammatical nits:

        +      <para>We can remove the watches registered on a znode with the call
        +      removeWatches. 
        

        "with a call to removeWatches"

         
        +      removeWatches. Also, ZooKeeper client can remove the watches locally
        +      when there is no server connection. This is possible by specifying 
        +      local flag to true. 
        

        "Also, a ZooKeeper client can remove watches locally even if there is no server connection by setting the local flag to true."

        +          <para>Watcher which was added with a call to exists, getData.</para>
        

        "to exists or getData."

        Thanks Rakesh R!

        Show
        Raul Gutierrez Segales added a comment - lgtm mostly - here are some small grammatical nits: + <para>We can remove the watches registered on a znode with the call + removeWatches. "with a call to removeWatches" + removeWatches. Also, ZooKeeper client can remove the watches locally + when there is no server connection. This is possible by specifying + local flag to true. "Also, a ZooKeeper client can remove watches locally even if there is no server connection by setting the local flag to true." + <para>Watcher which was added with a call to exists, getData.</para> "to exists or getData." Thanks Rakesh R !
        Rakesh R made changes -
        Attachment ZOOKEEPER-1831.patch [ 12627561 ]
        Hide
        Rakesh R added a comment -

        Thanks Raul Gutierrez Segales for the review. Attached reworked patch. Please have a look at it.

        Show
        Rakesh R added a comment - Thanks Raul Gutierrez Segales for the review. Attached reworked patch. Please have a look at it.
        Rakesh R made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12627561/ZOOKEEPER-1831.patch
        against trunk revision 1561672.

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1921//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1921//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1921//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12627561/ZOOKEEPER-1831.patch against trunk revision 1561672. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1921//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1921//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1921//console This message is automatically generated.
        Hide
        Raul Gutierrez Segales added a comment -

        +1, thanks Rakesh R.

        Show
        Raul Gutierrez Segales added a comment - +1, thanks Rakesh R .
        Hide
        Michi Mutsuzaki added a comment -

        +1 Thank you Rakesh!

        Show
        Michi Mutsuzaki added a comment - +1 Thank you Rakesh!
        Show
        Michi Mutsuzaki added a comment - http://svn.apache.org/viewvc?view=revision&revision=1584459
        Michi Mutsuzaki made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in ZooKeeper-trunk #2279 (See https://builds.apache.org/job/ZooKeeper-trunk/2279/)
        ZOOKEEPER-1831. Document remove watches details to the guide (Rakesh R via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1584459)

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in ZooKeeper-trunk #2279 (See https://builds.apache.org/job/ZooKeeper-trunk/2279/ ) ZOOKEEPER-1831 . Document remove watches details to the guide (Rakesh R via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1584459 ) /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        63d 21h 39m 1 Rakesh R 07/Feb/14 06:59
        Patch Available Patch Available Resolved Resolved
        55d 16h 14m 1 Michi Mutsuzaki 04/Apr/14 00:14

          People

          • Assignee:
            Rakesh R
            Reporter:
            Rakesh R
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development