ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1821

very ugly warning when compiling load_gen.c

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.6, 3.5.0
    • Fix Version/s: 3.4.6, 3.5.0
    • Component/s: c client
    • Labels:
      None
    • Environment:

      macos

      Description

      this is the compiler output:
      3.4/src/c/src/load_gen.c:110:1: warning: control may reach end of non-void function [-Wreturn-type]
      [exec] }
      [exec] ^
      3.4/src/c/src/load_gen.c:135:1: warning: control may reach end of non-void function [-Wreturn-type]
      [exec] }
      [exec] ^
      3.4/src/c/src/load_gen.c:163:1: warning: control may reach end of non-void function [-Wreturn-type]
      [exec] }
      [exec] ^
      3.4/src/c/src/load_gen.c:180:1: warning: control may reach end of non-void function [-Wreturn-type]
      [exec] }
      [exec] ^
      i think that the code is missing a "return ZOK" in the end of these functions.

      1. ZOOKEEPER-1821.patch
        0.9 kB
        Germán Blanco

        Activity

        Hide
        Flavio Junqueira added a comment -

        Closing issues after releasing 3.4.6.

        Show
        Flavio Junqueira added a comment - Closing issues after releasing 3.4.6.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in ZooKeeper-trunk #2134 (See https://builds.apache.org/job/ZooKeeper-trunk/2134/)
        ZOOKEEPER-1821. very ugly warning when compiling load_gen.c (german blanco via fpj) (fpj: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1546227)

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/c/src/load_gen.c
        Show
        Hudson added a comment - FAILURE: Integrated in ZooKeeper-trunk #2134 (See https://builds.apache.org/job/ZooKeeper-trunk/2134/ ) ZOOKEEPER-1821 . very ugly warning when compiling load_gen.c (german blanco via fpj) (fpj: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1546227 ) /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/c/src/load_gen.c
        Hide
        Flavio Junqueira added a comment -

        Trunk: Committed revision 1546227.
        B3.4: Committed revision 1546231.

        Show
        Flavio Junqueira added a comment - Trunk: Committed revision 1546227. B3.4: Committed revision 1546231.
        Hide
        Germán Blanco added a comment -

        Can I please get this committed?

        Show
        Germán Blanco added a comment - Can I please get this committed?
        Hide
        Flavio Junqueira added a comment -

        +1

        Show
        Flavio Junqueira added a comment - +1
        Hide
        Raul Gutierrez Segales added a comment -

        lgtm, +1.

        Show
        Raul Gutierrez Segales added a comment - lgtm, +1.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12615452/ZOOKEEPER-1821.patch
        against trunk revision 1543281.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1803//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1803//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1803//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615452/ZOOKEEPER-1821.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1803//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1803//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1803//console This message is automatically generated.
        Hide
        Germán Blanco added a comment -

        The patch adds "return ZOK" in the end of the functions.
        There are no new tests (there is no change in behaviour at all, only the warning is removed).

        Show
        Germán Blanco added a comment - The patch adds "return ZOK" in the end of the functions. There are no new tests (there is no change in behaviour at all, only the warning is removed).

          People

          • Assignee:
            Germán Blanco
            Reporter:
            Germán Blanco
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development