ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1814

Reduction of waiting time during Fast Leader Election

    Details

    • Type: Bug Bug
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 3.4.5, 3.5.0
    • Fix Version/s: 3.5.2, 3.6.0
    • Component/s: leaderElection
    • Labels:
      None

      Description

      FastLeader election takes long time because of the exponential backoff. Currently the time is 60 seconds.

      It would be interesting to give the possibility to configure this parameter, like for example for a Server shutdown.

      Otherwise, it sometimes takes so long and it has been detected a test failure when executing: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.

      This test case waits until 30 seconds and this is smaller than the 60 seconds where the leader election can be waiting for at the moment of shutting down.

      Considering the failure during the test case, this issue was considered a possible bug.

      1. ZOOKEEPER-1814_release_3_5_0.patch
        15 kB
        Daniel Peon
      2. ZOOKEEPER-1814_trunk.patch
        15 kB
        Daniel Peon
      3. ZOOKEEPER-1814.patch
        14 kB
        Daniel Peon
      4. ZOOKEEPER-1814.patch
        13 kB
        Daniel Peon
      5. ZOOKEEPER-1814.patch
        13 kB
        Daniel Peon
      6. ZOOKEEPER-1814.patch
        13 kB
        Daniel Peon
      7. ZOOKEEPER-1814.patch
        13 kB
        Daniel Peon
      8. ZOOKEEPER-1814.patch
        13 kB
        Daniel Peon
      9. ZOOKEEPER-1814.patch
        13 kB
        Daniel Peon
      10. ZOOKEEPER-1814.patch
        12 kB
        Daniel Peon
      11. ZOOKEEPER-1814.patch
        12 kB
        Daniel Peon

        Activity

        Daniel Peon created issue -
        Flavio Junqueira made changes -
        Field Original Value New Value
        Fix Version/s 3.4.6 [ 12323310 ]
        Hide
        Flavio Junqueira added a comment -

        Thanks for reporting this issue. The 60 seconds you're referring to is the worst case. Making the top interval configurable is not a bug, so it should go into 3.5.0. If you want to bump the test case timeout value because it causes failures, then please do it in a different jira. In any case, it is odd that the test even hits the 60s limit. I think it is premature to blame the 60s limit for the test failure.

        Show
        Flavio Junqueira added a comment - Thanks for reporting this issue. The 60 seconds you're referring to is the worst case. Making the top interval configurable is not a bug, so it should go into 3.5.0. If you want to bump the test case timeout value because it causes failures, then please do it in a different jira. In any case, it is odd that the test even hits the 60s limit. I think it is premature to blame the 60s limit for the test failure.
        Daniel Peon made changes -
        Assignee Daniel Peon [ danipeon ]
        Germán Blanco made changes -
        Summary Reduction of time during Leader election Reduction of waiting time during Fast Leader Election
        chenwencai made changes -
        Issue Type Bug [ 1 ] Test [ 6 ]
        Priority Major [ 3 ] Minor [ 4 ]
        Sebb made changes -
        Issue Type Test [ 6 ] Bug [ 1 ]
        Sebb made changes -
        Priority Minor [ 4 ] Major [ 3 ]
        Daniel Peon made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Daniel Peon added a comment -

        I attached a patch where the parameter maxNotificationInterval keeps its default value defined in FastLeaderElection source file, but also it is possible to configure the value of this parameter by using the configuration file.

        It is possible to find in the patch: source code modifications; a new test case that proves the configuration of the parameter (it can be tested that the test case fails if the source code modifications are deleted); a modification in the QuorumPeerMain test case which failed from time to time due to the value of this parameter; and the modifications in the Administration's Guide indicating the configurable parameter.

        Show
        Daniel Peon added a comment - I attached a patch where the parameter maxNotificationInterval keeps its default value defined in FastLeaderElection source file, but also it is possible to configure the value of this parameter by using the configuration file. It is possible to find in the patch: source code modifications; a new test case that proves the configuration of the parameter (it can be tested that the test case fails if the source code modifications are deleted); a modification in the QuorumPeerMain test case which failed from time to time due to the value of this parameter; and the modifications in the Administration's Guide indicating the configurable parameter.
        Daniel Peon made changes -
        Attachment patch-zk-1814.patch [ 12618198 ]
        Daniel Peon made changes -
        Attachment patch-zk-1814.patch [ 12618198 ]
        Hide
        Daniel Peon added a comment -

        I think I attached the file with a wrong name.

        Show
        Daniel Peon added a comment - I think I attached the file with a wrong name.
        Daniel Peon made changes -
        Attachment ZOOKEEPER-1814.patch [ 12618200 ]
        Daniel Peon made changes -
        Status In Progress [ 3 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12618200/ZOOKEEPER-1814.patch
        against trunk revision 1550005.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1825//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1825//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1825//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618200/ZOOKEEPER-1814.patch against trunk revision 1550005. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1825//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1825//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1825//console This message is automatically generated.
        Hide
        Daniel Peon added a comment -

        It seems that I created a warning.

        I'm going to correct it and upload a new patch.

        Show
        Daniel Peon added a comment - It seems that I created a warning. I'm going to correct it and upload a new patch.
        Daniel Peon made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Daniel Peon added a comment -

        New patch created after solving the warning.

        Show
        Daniel Peon added a comment - New patch created after solving the warning.
        Daniel Peon made changes -
        Attachment ZOOKEEPER-1814.patch [ 12618381 ]
        Daniel Peon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12618381/ZOOKEEPER-1814.patch
        against trunk revision 1550213.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1827//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1827//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1827//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618381/ZOOKEEPER-1814.patch against trunk revision 1550213. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1827//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1827//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1827//console This message is automatically generated.
        Hide
        Daniel Peon added a comment -

        Test case indentation was wrong. Additionally the sleep was avoided by adding countDownLatch mechanism.

        Show
        Daniel Peon added a comment - Test case indentation was wrong. Additionally the sleep was avoided by adding countDownLatch mechanism.
        Daniel Peon made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Daniel Peon added a comment -

        Uploaded new patch with correct test case indentation and CountDownLatch wait for the test case instead of sleep.

        Show
        Daniel Peon added a comment - Uploaded new patch with correct test case indentation and CountDownLatch wait for the test case instead of sleep.
        Daniel Peon made changes -
        Attachment ZOOKEEPER-1814.patch [ 12618428 ]
        Daniel Peon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Germán Blanco added a comment -

        Sorry I didn't catch this before, but if you need to update the patch again, perhaps it would make sense to set a smaller maxFleNotificationInterval time in the test (say 200 milliseconds instead of 5000), so that the test is faster and it doesn't add time to the already very long ZooKeeper regression.

        Show
        Germán Blanco added a comment - Sorry I didn't catch this before, but if you need to update the patch again, perhaps it would make sense to set a smaller maxFleNotificationInterval time in the test (say 200 milliseconds instead of 5000), so that the test is faster and it doesn't add time to the already very long ZooKeeper regression.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12618428/ZOOKEEPER-1814.patch
        against trunk revision 1550213.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1828//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1828//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1828//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618428/ZOOKEEPER-1814.patch against trunk revision 1550213. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1828//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1828//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1828//console This message is automatically generated.
        Hide
        Daniel Peon added a comment -

        That's right, I should have thought about that before. Right now the test case is introducing around 20 seconds to the execution and it is not necessary. I'm going to change it and upload the new patch.

        Show
        Daniel Peon added a comment - That's right, I should have thought about that before. Right now the test case is introducing around 20 seconds to the execution and it is not necessary. I'm going to change it and upload the new patch.
        Hide
        Daniel Peon added a comment -

        The test time is long and it can be reduced.

        Show
        Daniel Peon added a comment - The test time is long and it can be reduced.
        Daniel Peon made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Daniel Peon added a comment -

        In the test case, maxFleNotificationInterval parameter has been reduced.

        Show
        Daniel Peon added a comment - In the test case, maxFleNotificationInterval parameter has been reduced.
        Daniel Peon made changes -
        Attachment ZOOKEEPER-1814.patch [ 12618436 ]
        Daniel Peon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Daniel Peon added a comment -

        Wrong indentation in one line in the test case.

        Show
        Daniel Peon added a comment - Wrong indentation in one line in the test case.
        Daniel Peon made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Daniel Peon added a comment -

        Updated with the right indentation in one line in the test case.

        Show
        Daniel Peon added a comment - Updated with the right indentation in one line in the test case.
        Daniel Peon made changes -
        Attachment ZOOKEEPER-1814.patch [ 12618438 ]
        Daniel Peon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12618436/ZOOKEEPER-1814.patch
        against trunk revision 1550213.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1829//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1829//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1829//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618436/ZOOKEEPER-1814.patch against trunk revision 1550213. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1829//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1829//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1829//console This message is automatically generated.
        Hide
        Raul Gutierrez Segales added a comment -

        Some nits and simplifications:

        +              <para><emphasis role="bold">New in 3.3.0:</emphasis>Maximum notifications
        

        3.3.0 doesn't seem right.

        Nit:

        -     * should not be taken into account in the comparison 
        -     * (electionEpoch and zxid). 
        +     * should not be taken into account in the comparison
        +     * (electionEpoch and zxid).
        

        those lines didn't really change, you just introduced a trailing space.

        Instead of:

        +        if (System.getProperty("zookeeper.maxFleNotificationInterval") != null){
        +            maxNotificationInterval = Integer.parseInt(System.getProperty("zookeeper.maxFleNotificationInterval"));
        +        } else {
        +            maxNotificationInterval = 60000;
        +        }
        

        you can just have:

        maxNotificationInterval = Integer.getInteger("zookeeper.maxFleNotificationInterval", 60000);
        

        Nit: for all the LOG.info/LOG.debug statements, I think it's cleaner to use string extrapolation as opposed to concatenating strings. i.e.: instead of:

        LOG.info("Two equal notification intervals measured [" + counter + " of "
        +                                + numEqualIntervalsNeeded + "]");
        

        just:

        LOG.info("Two equal notification intervals measured [{} of {}]", counter, numEqualIntervalsNeeded);
        

        Instead of:

        +        maxFleNotificationInterval = Integer.parseInt(System.getProperty("zookeeper.maxFleNotificationInterval"));
        

        just:

        +        maxFleNotificationInterval = Integer.getInteger("zookeeper.maxFleNotificationInterval");
        

        you probably want to make "zookeeper.maxFleNotificationInterval" a public constant somewhere.

        Instead of:

        +        if (thread.isAlive()) {
        +            Assert.fail("Should not be alive");
        +        }
        

        maybe just:

        +          Assert.assertFalse("Should not be alive", thread.isAlive());
        
        Show
        Raul Gutierrez Segales added a comment - Some nits and simplifications: + <para><emphasis role="bold">New in 3.3.0:</emphasis>Maximum notifications 3.3.0 doesn't seem right. Nit: - * should not be taken into account in the comparison - * (electionEpoch and zxid). + * should not be taken into account in the comparison + * (electionEpoch and zxid). those lines didn't really change, you just introduced a trailing space. Instead of: + if (System.getProperty("zookeeper.maxFleNotificationInterval") != null){ + maxNotificationInterval = Integer.parseInt(System.getProperty("zookeeper.maxFleNotificationInterval")); + } else { + maxNotificationInterval = 60000; + } you can just have: maxNotificationInterval = Integer.getInteger("zookeeper.maxFleNotificationInterval", 60000); Nit: for all the LOG.info/LOG.debug statements, I think it's cleaner to use string extrapolation as opposed to concatenating strings. i.e.: instead of: LOG.info("Two equal notification intervals measured [" + counter + " of " + + numEqualIntervalsNeeded + "]"); just: LOG.info("Two equal notification intervals measured [{} of {}]", counter, numEqualIntervalsNeeded); Instead of: + maxFleNotificationInterval = Integer.parseInt(System.getProperty("zookeeper.maxFleNotificationInterval")); just: + maxFleNotificationInterval = Integer.getInteger("zookeeper.maxFleNotificationInterval"); you probably want to make "zookeeper.maxFleNotificationInterval" a public constant somewhere. Instead of: + if (thread.isAlive()) { + Assert.fail("Should not be alive"); + } maybe just: + Assert.assertFalse("Should not be alive", thread.isAlive());
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12618438/ZOOKEEPER-1814.patch
        against trunk revision 1550213.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1830//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1830//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1830//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618438/ZOOKEEPER-1814.patch against trunk revision 1550213. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1830//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1830//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1830//console This message is automatically generated.
        Hide
        Daniel Peon added a comment -

        Thanks for the comments. I'm generating a new patch file with the suggested changes. The only issue is:

        Nit:

        • * should not be taken into account in the comparison
        • * (electionEpoch and zxid).
          + * should not be taken into account in the comparison
          + * (electionEpoch and zxid).
          those lines didn't really change, you just introduced a trailing space.

        When I download the trunk version of the code, those spaces at the end of those 2 lines appear. Thus, Review Board complains if I do not delete them when I created the diff file.

        Show
        Daniel Peon added a comment - Thanks for the comments. I'm generating a new patch file with the suggested changes. The only issue is: Nit: * should not be taken into account in the comparison * (electionEpoch and zxid). + * should not be taken into account in the comparison + * (electionEpoch and zxid). those lines didn't really change, you just introduced a trailing space. When I download the trunk version of the code, those spaces at the end of those 2 lines appear. Thus, Review Board complains if I do not delete them when I created the diff file.
        Hide
        Daniel Peon added a comment -

        Applying suggested comments.

        Show
        Daniel Peon added a comment - Applying suggested comments.
        Daniel Peon made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Daniel Peon added a comment -

        Few changes applied from recent comments:

        -Docummentation has been corrected.
        -The way to get the value from properties has been simplified.
        -Corrections in test case: LOG and assert statements.

        Show
        Daniel Peon added a comment - Few changes applied from recent comments: -Docummentation has been corrected. -The way to get the value from properties has been simplified. -Corrections in test case: LOG and assert statements.
        Daniel Peon made changes -
        Attachment ZOOKEEPER-1814.patch [ 12618561 ]
        Daniel Peon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12618561/ZOOKEEPER-1814.patch
        against trunk revision 1550213.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1833//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1833//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1833//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618561/ZOOKEEPER-1814.patch against trunk revision 1550213. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1833//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1833//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1833//console This message is automatically generated.
        Hide
        Daniel Peon added a comment -

        Corrected suggested changes in Review Board (extra spaces, extra fflush and string concatenation).

        Show
        Daniel Peon added a comment - Corrected suggested changes in Review Board (extra spaces, extra fflush and string concatenation).
        Daniel Peon made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Daniel Peon made changes -
        Attachment ZOOKEEPER-1814.patch [ 12618872 ]
        Daniel Peon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12618872/ZOOKEEPER-1814.patch
        against trunk revision 1551119.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1840//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1840//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1840//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618872/ZOOKEEPER-1814.patch against trunk revision 1551119. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1840//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1840//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1840//console This message is automatically generated.
        Hide
        Michi Mutsuzaki added a comment -

        This patch doesn't apply anymore. It seems like the latest patch addressed all the feedback. I'll check this in once the patch is rebased.

        Show
        Michi Mutsuzaki added a comment - This patch doesn't apply anymore. It seems like the latest patch addressed all the feedback. I'll check this in once the patch is rebased.
        Michi Mutsuzaki made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Flavio Junqueira added a comment -

        It is fine if you want to make this configurable, but I'd say that we need to do a better job explaining the impact of changing it. For example, we could start by saying that servers keep sending batches until they are able to make progress with leader election. We keep increasing the time between batches so that we don't keep sending messages unnecessarily, and we increase the time between batches until we reach a threshold, which is what this parameter sets.

        Actually, the choice of 60s was somewhat arbitrary. Is there a reason for having a different threshold?

        Show
        Flavio Junqueira added a comment - It is fine if you want to make this configurable, but I'd say that we need to do a better job explaining the impact of changing it. For example, we could start by saying that servers keep sending batches until they are able to make progress with leader election. We keep increasing the time between batches so that we don't keep sending messages unnecessarily, and we increase the time between batches until we reach a threshold, which is what this parameter sets. Actually, the choice of 60s was somewhat arbitrary. Is there a reason for having a different threshold?
        Hide
        Daniel Peon added a comment -

        Hi,

        Reason of modification:
        ----------------------------
        When the FastLeaderElection process reaches a big timeout, the process waits until that timeout before taking control. Thus, if a shutdown happens during that waiting time, the process doesn't realize of the shutdown until the timeout, which is so long. Reducing the maximum time to a reasonable value (2-5 seconds) we are not sending a heavy traffic, but we can detect a shutdown in few seconds instead of 1 minute in the worst case.

        Reason of configurable parameter:
        -------------------------------------------
        We may have chosen a fixed value, but the reason of making maxFleNotificationInterval a configurable parameter is backward compatibility. If someone's deployment is already working by using that 60 seconds maximum time for any reason, I didn't want to modify the default behavior.

        Regards.

        Show
        Daniel Peon added a comment - Hi, Reason of modification: ---------------------------- When the FastLeaderElection process reaches a big timeout, the process waits until that timeout before taking control. Thus, if a shutdown happens during that waiting time, the process doesn't realize of the shutdown until the timeout, which is so long. Reducing the maximum time to a reasonable value (2-5 seconds) we are not sending a heavy traffic, but we can detect a shutdown in few seconds instead of 1 minute in the worst case. Reason of configurable parameter: ------------------------------------------- We may have chosen a fixed value, but the reason of making maxFleNotificationInterval a configurable parameter is backward compatibility. If someone's deployment is already working by using that 60 seconds maximum time for any reason, I didn't want to modify the default behavior. Regards.
        Hide
        Flavio Junqueira added a comment -

        I possibly haven't made it clear that I'm suggesting we do a better job in the change to the documentation. I think the text there is a bit thin and not really explaining how it affects a deployment and why one should care about it.

        but we can detect a shutdown in few seconds instead of 1 minute in the worst case.

        Is this referring to tests or something else? If this is not referring to tests, then I'm not sure how it helps to detect a shutdown faster.

        If someone's deployment is already working by using that 60 seconds maximum time for any reason, I didn't want to modify the default behavior.

        It makes sense.

        Show
        Flavio Junqueira added a comment - I possibly haven't made it clear that I'm suggesting we do a better job in the change to the documentation. I think the text there is a bit thin and not really explaining how it affects a deployment and why one should care about it. but we can detect a shutdown in few seconds instead of 1 minute in the worst case. Is this referring to tests or something else? If this is not referring to tests, then I'm not sure how it helps to detect a shutdown faster. If someone's deployment is already working by using that 60 seconds maximum time for any reason, I didn't want to modify the default behavior. It makes sense.
        Hide
        Daniel Peon added a comment -

        Sorry, I read your comment too fast. Now it is clear. I'm going to update the documentation with more details like you suggested.

        Show
        Daniel Peon added a comment - Sorry, I read your comment too fast. Now it is clear. I'm going to update the documentation with more details like you suggested.
        Hide
        Daniel Peon added a comment -

        Modified the documentation according the provided comments. Documentation of the introduced configurable parameter was poor and it is explained better in this version.

        Show
        Daniel Peon added a comment - Modified the documentation according the provided comments. Documentation of the introduced configurable parameter was poor and it is explained better in this version.
        Daniel Peon made changes -
        Attachment ZOOKEEPER-1814.patch [ 12638212 ]
        Hide
        Daniel Peon added a comment -

        Modified the documentation according the provided comments. Documentation of the introduced configurable parameter was poor and it is explained better in this version.

        Show
        Daniel Peon added a comment - Modified the documentation according the provided comments. Documentation of the introduced configurable parameter was poor and it is explained better in this version.
        Daniel Peon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12638212/ZOOKEEPER-1814.patch
        against trunk revision 1583783.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2020//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12638212/ZOOKEEPER-1814.patch against trunk revision 1583783. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2020//console This message is automatically generated.
        Hide
        Daniel Peon added a comment -

        The patch cannot be applied properly due to the revision when it has been generated. A new one is being generated.

        Show
        Daniel Peon added a comment - The patch cannot be applied properly due to the revision when it has been generated. A new one is being generated.
        Daniel Peon made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Daniel Peon added a comment -

        Previos patch cannot be applied due to a conflict in the merge.

        Show
        Daniel Peon added a comment - Previos patch cannot be applied due to a conflict in the merge.
        Daniel Peon made changes -
        Attachment ZOOKEEPER-1814.patch [ 12638226 ]
        Daniel Peon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12638226/ZOOKEEPER-1814.patch
        against trunk revision 1583783.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2021//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2021//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2021//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12638226/ZOOKEEPER-1814.patch against trunk revision 1583783. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2021//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2021//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2021//console This message is automatically generated.
        Hide
        Michi Mutsuzaki added a comment -

        Flavio, could you take a look at the updated patch when you get a chance?

        Thanks!

        Show
        Michi Mutsuzaki added a comment - Flavio, could you take a look at the updated patch when you get a chance? Thanks!
        Hide
        Raul Gutierrez Segales added a comment -

        fwiw +1, this looks great to me.

        Show
        Raul Gutierrez Segales added a comment - fwiw +1, this looks great to me.
        Patrick Hunt made changes -
        Fix Version/s 3.5.1 [ 12326786 ]
        Fix Version/s 3.5.0 [ 12316644 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12638226/ZOOKEEPER-1814.patch
        against trunk revision 1615240.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2254//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12638226/ZOOKEEPER-1814.patch against trunk revision 1615240. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2254//console This message is automatically generated.
        Hide
        Daniel Peon added a comment -

        Hi!

        Just to confirm, how many +1 are needed for a patch to be ready?

        Thanks and regards.

        Show
        Daniel Peon added a comment - Hi! Just to confirm, how many +1 are needed for a patch to be ready? Thanks and regards.
        Hide
        Daniel Peon added a comment -

        Hi again,

        After the +1 received by Raul, I didn't realize about the error reported by Hadoop QA. The patch cannot be applied to trunk. I tried to apply it directly to the today's trunk and it is not possible due to there are a lot of changes since I created the patch.

        Should I correct it for trunk or should I generate the patch for 3.4.5 release where I found the issue?

        Thanks in advance and regards.

        Show
        Daniel Peon added a comment - Hi again, After the +1 received by Raul, I didn't realize about the error reported by Hadoop QA. The patch cannot be applied to trunk. I tried to apply it directly to the today's trunk and it is not possible due to there are a lot of changes since I created the patch. Should I correct it for trunk or should I generate the patch for 3.4.5 release where I found the issue? Thanks in advance and regards.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12638226/ZOOKEEPER-1814.patch
        against trunk revision 1634776.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2403//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12638226/ZOOKEEPER-1814.patch against trunk revision 1634776. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2403//console This message is automatically generated.
        Hide
        Daniel Peon added a comment -

        After starting to adapt my patch to the current trunk version, I've realized that the test case that I created uses the LEThread static class. Previously this class was in the same package (org.apache.zookeeper.test.FLETestUtils.LEThread) but currently it is in a different package (org.apache.zookeeper.server.quorum.FLETestUtils.LEThread).

        Since it is not in the same package, it is not accesible by my testcase. Is there any specific reason why the static class LEThread extends Thread is declared without visibility modifier? Is it possible to change the visibility to public?

        Show
        Daniel Peon added a comment - After starting to adapt my patch to the current trunk version, I've realized that the test case that I created uses the LEThread static class. Previously this class was in the same package (org.apache.zookeeper.test.FLETestUtils.LEThread) but currently it is in a different package (org.apache.zookeeper.server.quorum.FLETestUtils.LEThread). Since it is not in the same package, it is not accesible by my testcase. Is there any specific reason why the static class LEThread extends Thread is declared without visibility modifier? Is it possible to change the visibility to public?
        Hide
        Flavio Junqueira added a comment -

        if we are going to include this feature at all, then I'd say that having a trunk patch makes sense (a 3.5 branch patch as well). Could you check with svn blame which jira caused the modification you observed?

        Show
        Flavio Junqueira added a comment - if we are going to include this feature at all, then I'd say that having a trunk patch makes sense (a 3.5 branch patch as well). Could you check with svn blame which jira caused the modification you observed?
        Flavio Junqueira made changes -
        Fix Version/s 3.4.7 [ 12325149 ]
        Fix Version/s 3.6.0 [ 12326518 ]
        Hide
        Daniel Peon added a comment -

        Ok, I'll adapt the patch to trunk branch and I'll test it for 3.5 branch also.

        The change that I commented above about the FLETestUtils.java file corresponds to the revision: 1608648

        >>Revision: 1608648
        >>Author: michim
        >>Date: martes, 08 de julio de 2014 5:25:56
        >>Message:
        >>ZOOKEEPER-1810. Add version to FLE notifications for trunk Germán Blanco via michim)

        If I can change the visibility of the class it will be easy the adaption of the test case.

        Thanks in advance and regards.

        Show
        Daniel Peon added a comment - Ok, I'll adapt the patch to trunk branch and I'll test it for 3.5 branch also. The change that I commented above about the FLETestUtils.java file corresponds to the revision: 1608648 >>Revision: 1608648 >>Author: michim >>Date: martes, 08 de julio de 2014 5:25:56 >>Message: >> ZOOKEEPER-1810 . Add version to FLE notifications for trunk Germán Blanco via michim) If I can change the visibility of the class it will be easy the adaption of the test case. Thanks in advance and regards.
        Hide
        Daniel Peon added a comment -

        Patch cannot be applied to current trunk version due to there have been a lot of changes since the patch was uploaded.

        A new ann adapted patch is going to be uploaded.

        Show
        Daniel Peon added a comment - Patch cannot be applied to current trunk version due to there have been a lot of changes since the patch was uploaded. A new ann adapted patch is going to be uploaded.
        Daniel Peon made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Daniel Peon added a comment -

        Please find attached the following files:

        -ZOOKEEPER-1814_trunk.patch
        -ZOOKEEPER-1814_release_3_5_0.patch

        I've uploaded those patches with a non-standard naming due to they have been created for trunk and release_3_5_0 branches respectively. Let me know if I did wrong and if I should upload with different names.

        Regards.

        Show
        Daniel Peon added a comment - Please find attached the following files: - ZOOKEEPER-1814 _trunk.patch - ZOOKEEPER-1814 _release_3_5_0.patch I've uploaded those patches with a non-standard naming due to they have been created for trunk and release_3_5_0 branches respectively. Let me know if I did wrong and if I should upload with different names. Regards.
        Daniel Peon made changes -
        Attachment ZOOKEEPER-1814_trunk.patch [ 12678141 ]
        Attachment ZOOKEEPER-1814_release_3_5_0.patch [ 12678142 ]
        Hide
        Daniel Peon added a comment -

        Patch is available for review both for trunk and 3.5.0 branches.

        Show
        Daniel Peon added a comment - Patch is available for review both for trunk and 3.5.0 branches.
        Daniel Peon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12678142/ZOOKEEPER-1814_release_3_5_0.patch
        against trunk revision 1634776.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2408//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2408//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2408//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12678142/ZOOKEEPER-1814_release_3_5_0.patch against trunk revision 1634776. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2408//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2408//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2408//console This message is automatically generated.
        Hide
        Daniel Peon added a comment -

        Hi,

        Is the "testCurrentServersAreObserversInNextConfig" test in the file "ReconfigRecoveryTest.java" sometimes failing? I ran the regression on my machine several times and I got a 100% passed all the times. Is there any known issue about it?

        Thanks and regards.

        Show
        Daniel Peon added a comment - Hi, Is the "testCurrentServersAreObserversInNextConfig" test in the file "ReconfigRecoveryTest.java" sometimes failing? I ran the regression on my machine several times and I got a 100% passed all the times. Is there any known issue about it? Thanks and regards.
        Hide
        Daniel Peon added a comment -

        Hi again,

        I've found out what happened. The patch which has been tested is the one uploaded for 3.5.0 release.

        How can I deal with these two patches in order to be tested by Hadoop QA in their corresponding branches? Or should I upload the 3.5.0 patch to other place/ticket?

        Show
        Daniel Peon added a comment - Hi again, I've found out what happened. The patch which has been tested is the one uploaded for 3.5.0 release. How can I deal with these two patches in order to be tested by Hadoop QA in their corresponding branches? Or should I upload the 3.5.0 patch to other place/ticket?
        Michi Mutsuzaki made changes -
        Fix Version/s 3.5.2 [ 12331981 ]
        Fix Version/s 3.4.7 [ 12325149 ]
        Fix Version/s 3.5.1 [ 12326786 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12678142/ZOOKEEPER-1814_release_3_5_0.patch
        against trunk revision 1672934.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2612//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2612//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2612//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12678142/ZOOKEEPER-1814_release_3_5_0.patch against trunk revision 1672934. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2612//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2612//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2612//console This message is automatically generated.
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        25d 21h 43m 1 Daniel Peon 11/Dec/13 08:21
        In Progress In Progress Patch Available Patch Available
        36m 34s 1 Daniel Peon 11/Dec/13 08:57
        Patch Available Patch Available Open Open
        319d 9h 9 Daniel Peon 30/Oct/14 08:09
        Open Open Patch Available Patch Available
        3d 14h 16m 9 Daniel Peon 30/Oct/14 08:14

          People

          • Assignee:
            Daniel Peon
            Reporter:
            Daniel Peon
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development