[ZOOKEEPER-1797] PurgeTxnLog may delete data logs during roll

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 3.4.5
• Fix Version/s: 3.4.7, 3.5.0
• Component/s: server
• Assignee: Rakesh Radhakrishnan
• Reporter: Derek Dagit
• Created: 18/Oct/13 18:57
• Updated: 11/Sep/16 00:06
• Resolved: 18/May/14 01:05

Description

org.apache.zookeeper.server.PurgeTxnLog deletes old data logs and snapshots, keeping the newest N snapshots and any data logs that have been written since the snapshot.

It does this by listing the available snapshots & logs and creates a blacklist of snapshots and logs that should not be deleted. Then, it searches for and deletes all logs and snapshots that are not in this list.

It appears that if logs are rolling or a new snapshot is created during this process, then these newer files will be unintentionally deleted.

Issue Links

• breaks: ZOOKEEPER-2574 PurgeTxnLog can inadvertently delete required txn log files