ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1699

Leader should timeout and give up leadership when losing quorum of last proposed configuration

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.5.0
    • Fix Version/s: 3.5.0
    • Component/s: server
    • Labels:
      None

      Description

      A leader gives up leadership when losing a quorum of the current configuration.
      This doesn't take into account any proposed configuration. So, if
      a reconfig operation is in progress and a quorum of the new configuration is not
      responsive, the leader will just get stuck waiting for it to ACK the reconfig operation, and will never timeout.

      1. ZOOKEEPER-1699.patch
        5 kB
        Alexander Shraer
      2. ZOOKEEPER-1699-v1.patch
        5 kB
        Alexander Shraer
      3. ZOOKEEPER-1699-v2.patch
        8 kB
        Alexander Shraer
      4. ZOOKEEPER-1699-v3.patch
        7 kB
        Alexander Shraer
      5. ZOOKEEPER-1699-v4.patch
        7 kB
        Alexander Shraer
      6. ZOOKEEPER-1699-v4.patch
        7 kB
        Alexander Shraer
      7. ZOOKEEPER-1699-draft.patch
        11 kB
        Flavio Junqueira
      8. ZOOKEEPER-1699-draft.patch
        12 kB
        Flavio Junqueira
      9. ZOOKEEPER-1699-v5.patch
        12 kB
        Flavio Junqueira

        Activity

        Hide
        Alexander Shraer added a comment -

        Please take a look. Still need to figure out how to test this, any suggestions welcome.

        Show
        Alexander Shraer added a comment - Please take a look. Still need to figure out how to test this, any suggestions welcome.
        Show
        Alexander Shraer added a comment - https://reviews.apache.org/r/20287/
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12639964/ZOOKEEPER-1699.patch
        against trunk revision 1586200.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2039//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2039//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2039//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12639964/ZOOKEEPER-1699.patch against trunk revision 1586200. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2039//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2039//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2039//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12639967/ZOOKEEPER-1699-v1.patch
        against trunk revision 1586200.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2040//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2040//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2040//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12639967/ZOOKEEPER-1699-v1.patch against trunk revision 1586200. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2040//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2040//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2040//console This message is automatically generated.
        Hide
        Alexander Shraer added a comment -

        Includes a new test. The test consistently fails without the changes in Leader.java and passes with the changes.

        Without the changes in Leader.java, instead of moving into LOOKING state, the servers remain in Leader/Follower state - leader has quorum of old config but is stuck waiting for an ACK it needs to complete a quorum of new config.

        Show
        Alexander Shraer added a comment - Includes a new test. The test consistently fails without the changes in Leader.java and passes with the changes. Without the changes in Leader.java, instead of moving into LOOKING state, the servers remain in Leader/Follower state - leader has quorum of old config but is stuck waiting for an ACK it needs to complete a quorum of new config.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12639974/ZOOKEEPER-1699-v2.patch
        against trunk revision 1586200.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2041//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2041//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2041//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12639974/ZOOKEEPER-1699-v2.patch against trunk revision 1586200. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2041//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2041//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2041//console This message is automatically generated.
        Hide
        Benjamin Reed added a comment -

        you have some tabs that should be spaces.

        why are you catching the interrupted exceptions? if you take too long, an InterruptedException will be thrown after the while loop anyway.

        Show
        Benjamin Reed added a comment - you have some tabs that should be spaces. why are you catching the interrupted exceptions? if you take too long, an InterruptedException will be thrown after the while loop anyway.
        Hide
        Alexander Shraer added a comment -

        Thanks Ben! Attaching a new patch that reflects your comments.

        Show
        Alexander Shraer added a comment - Thanks Ben! Attaching a new patch that reflects your comments.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12640025/ZOOKEEPER-1699-v3.patch
        against trunk revision 1586200.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2043//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2043//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2043//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12640025/ZOOKEEPER-1699-v3.patch against trunk revision 1586200. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2043//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2043//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2043//console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        Hi Alexander Shraer,

        It looks good. The use of Proposal seems to be convenient because of the hasAllQuorums call, but it sounds a bit out of place. Could we use the quorum verifier directly instead?

        In the case we don't follow this suggestion, we should at least call it something else other than dummyProposal, like syncedAckSet or something like that.

        Show
        Flavio Junqueira added a comment - Hi Alexander Shraer , It looks good. The use of Proposal seems to be convenient because of the hasAllQuorums call, but it sounds a bit out of place. Could we use the quorum verifier directly instead? In the case we don't follow this suggestion, we should at least call it something else other than dummyProposal, like syncedAckSet or something like that.
        Hide
        Alexander Shraer added a comment -

        Hi Flavio,

        I actually like a lot that we can reuse the Proposal logic here and not duplicate it. Its not only the hasallquorums, but also the fact that we have potentially multiple quorumverifiers and we need to have a separate ackSet for each one, such that only appropriate voters have an ack in the appropriate ackSet. The reason is that the normal quorumverifier check for majority only checks that the number of votes is more than half, it doesn't check the votes themselves - we have to do that before adding the acks.

        I changed the name as you suggest.

        Thanks,
        Alex

        Show
        Alexander Shraer added a comment - Hi Flavio, I actually like a lot that we can reuse the Proposal logic here and not duplicate it. Its not only the hasallquorums, but also the fact that we have potentially multiple quorumverifiers and we need to have a separate ackSet for each one, such that only appropriate voters have an ack in the appropriate ackSet. The reason is that the normal quorumverifier check for majority only checks that the number of votes is more than half, it doesn't check the votes themselves - we have to do that before adding the acks. I changed the name as you suggest. Thanks, Alex
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12640106/ZOOKEEPER-1699-v4.patch
        against trunk revision 1586200.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2044//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2044//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2044//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12640106/ZOOKEEPER-1699-v4.patch against trunk revision 1586200. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2044//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2044//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2044//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12640597/ZOOKEEPER-1807-ver6.patch
        against trunk revision 1588141.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2047//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2047//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2047//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12640597/ZOOKEEPER-1807-ver6.patch against trunk revision 1588141. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2047//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2047//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2047//console This message is automatically generated.
        Hide
        Alexander Shraer added a comment -

        oops attached a 1807 patch here by mistake, resubmitting latest patch for 1699

        Show
        Alexander Shraer added a comment - oops attached a 1807 patch here by mistake, resubmitting latest patch for 1699
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12640654/ZOOKEEPER-1699-v4.patch
        against trunk revision 1588141.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2050//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2050//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2050//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12640654/ZOOKEEPER-1699-v4.patch against trunk revision 1588141. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2050//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2050//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2050//console This message is automatically generated.
        Hide
        Alexander Shraer added a comment -
        Show
        Alexander Shraer added a comment - ping Flavio Junqueira Benjamin Reed
        Hide
        Flavio Junqueira added a comment -

        The test failure in the last QA run seems to be due to ZOOKEEPER-1870 and unrelated to this issue. More comments soon.

        Show
        Flavio Junqueira added a comment - The test failure in the last QA run seems to be due to ZOOKEEPER-1870 and unrelated to this issue. More comments soon.
        Hide
        Flavio Junqueira added a comment -

        What do you think of this, Alexander Shraer? I just shuffled things around a bit to make intention more clear.

        Show
        Flavio Junqueira added a comment - What do you think of this, Alexander Shraer ? I just shuffled things around a bit to make intention more clear.
        Hide
        Flavio Junqueira added a comment -

        Forgot license header in a new file... just in case.

        Show
        Flavio Junqueira added a comment - Forgot license header in a new file... just in case.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12643975/ZOOKEEPER-1699-draft.patch
        against trunk revision 1592341.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2082//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2082//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2082//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12643975/ZOOKEEPER-1699-draft.patch against trunk revision 1592341. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2082//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2082//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2082//console This message is automatically generated.
        Hide
        Michi Mutsuzaki added a comment -

        Alexander Shraer, could you take a look at the patch when you get a chance? If it looks good to you, I'll check it in.

        Show
        Michi Mutsuzaki added a comment - Alexander Shraer , could you take a look at the patch when you get a chance? If it looks good to you, I'll check it in.
        Hide
        Alexander Shraer added a comment -

        Thanks Flavio, it looks good to me. The only suggestion is perhaps to remove this comment in Leader.java, " // The following "proposal" is not sent,... " since this is no longer a "Proposal" this explanation isn't needed.

        Michi, the test result link above doesn't work for me, but if you think that tests pass please check this in.

        Show
        Alexander Shraer added a comment - Thanks Flavio, it looks good to me. The only suggestion is perhaps to remove this comment in Leader.java, " // The following "proposal" is not sent,... " since this is no longer a "Proposal" this explanation isn't needed. Michi, the test result link above doesn't work for me, but if you think that tests pass please check this in.
        Hide
        Flavio Junqueira added a comment -

        I have updated the comment and renamed the diff file.

        Show
        Flavio Junqueira added a comment - I have updated the comment and renamed the diff file.
        Hide
        Alexander Shraer added a comment -

        +1

        Show
        Alexander Shraer added a comment - +1
        Show
        Michi Mutsuzaki added a comment - I started the precommit build. https://builds.apache.org/view/S-Z/view/ZooKeeper/job/PreCommit-ZOOKEEPER-Build/2098/
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12644628/ZOOKEEPER-1699-v5.patch
        against trunk revision 1595038.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2098//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2098//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2098//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12644628/ZOOKEEPER-1699-v5.patch against trunk revision 1595038. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2098//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2098//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2098//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12644628/ZOOKEEPER-1699-v5.patch
        against trunk revision 1595273.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2100//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2100//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2100//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12644628/ZOOKEEPER-1699-v5.patch against trunk revision 1595273. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2100//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2100//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2100//console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        It seems that there is something going on with startSingleServerTest. I'm looking into it, but if you have any insight, Alexander Shraer, let me know.

        Show
        Flavio Junqueira added a comment - It seems that there is something going on with startSingleServerTest. I'm looking into it, but if you have any insight, Alexander Shraer , let me know.
        Hide
        Michi Mutsuzaki added a comment -

        This patch should fix the issue. It hasn't been committed yet.

        https://issues.apache.org/jira/browse/ZOOKEEPER-1870

        Show
        Michi Mutsuzaki added a comment - This patch should fix the issue. It hasn't been committed yet. https://issues.apache.org/jira/browse/ZOOKEEPER-1870
        Hide
        Flavio Junqueira added a comment -

        Ok, good, so this one is good to go then.

        Show
        Flavio Junqueira added a comment - Ok, good, so this one is good to go then.
        Hide
        Michi Mutsuzaki added a comment -

        Sounds good, I'm checking this in.

        Show
        Michi Mutsuzaki added a comment - Sounds good, I'm checking this in.
        Show
        Michi Mutsuzaki added a comment - trunk: http://svn.apache.org/viewvc?view=revision&revision=1596422
        Hide
        Rakesh R added a comment -

        Hi Michi Mutsuzaki, It looks like we missed to checkin the newly added class "SyncedLearnerTracker.java" ?

        Show
        Rakesh R added a comment - Hi Michi Mutsuzaki , It looks like we missed to checkin the newly added class "SyncedLearnerTracker.java" ?
        Hide
        Rakesh R added a comment -

        Just re-opening the issue, please close the issue after checking this in. Thanks!

        Show
        Rakesh R added a comment - Just re-opening the issue, please close the issue after checking this in. Thanks!
        Hide
        Michi Mutsuzaki added a comment -

        Oops sorry about that.

        Show
        Michi Mutsuzaki added a comment - Oops sorry about that.
        Show
        Michi Mutsuzaki added a comment - trunk: http://svn.apache.org/viewvc?view=revision&revision=1596635
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in ZooKeeper-trunk #2312 (See https://builds.apache.org/job/ZooKeeper-trunk/2312/)
        ZOOKEEPER-1699. Forgot to add a new file. (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1596635)

        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/SyncedLearnerTracker.java
          ZOOKEEPER-1699. Leader should timeout and give up leadership when losing quorum of last proposed configuration (Alexander Shraer via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1596422)
        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java
        Show
        Hudson added a comment - SUCCESS: Integrated in ZooKeeper-trunk #2312 (See https://builds.apache.org/job/ZooKeeper-trunk/2312/ ) ZOOKEEPER-1699 . Forgot to add a new file. (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1596635 ) /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/SyncedLearnerTracker.java ZOOKEEPER-1699 . Leader should timeout and give up leadership when losing quorum of last proposed configuration (Alexander Shraer via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1596422 ) /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java

          People

          • Assignee:
            Alexander Shraer
            Reporter:
            Alexander Shraer
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development