[ZOOKEEPER-1610] Some classes are using == or != to compare Long/String objects instead of .equals()

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.4.5, 3.5.0
• Fix Version/s: 3.4.6, 3.5.0
• Component/s: java client, quorum
• Hadoop Flags: Reviewed
• Assignee: Edward Ribeiro
• Reporter: Edward Ribeiro
• Due: 26/Dec/12
• Created: 26/Dec/12 17:31
• Updated: 13/Mar/14 18:17
• Resolved: 11/Oct/13 19:19

Description

The classes org.apache.zookeeper.client.ZooKeeperSaslClient.java and
org.apache.zookeeper.server.quorum.flexible.QuorumHierarchical.java compare Strings and/or Longs using referential equality.

Usually, this is not a problem because the Longs are cached and Strings are interned, but I myself had problems with those kind of comparisons in the past because one production JVM didn't reused the objects.