Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-1574

mismatched CR/LF endings in text files

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.6, 3.5.0
    • Fix Version/s: 3.4.7, 3.5.0
    • Component/s: None
    • Labels:
      None

      Description

      Source code in zookeeper repo has a bunch of files that have CRLF endings.
      With more development happening on windows there is a higher chance of more CRLF files getting into the source tree.
      I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
      But before adding the .gitattributes file we need to normalize the existing tree, so that people when they sync after .giattributes change wont end up with a bunch of modified files in their workspace.
      I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
      http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
      http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
      I will submit a separate bug and patch for .gitattributes

        Attachments

        1. ZOOKEEPER-1574.branch-3.4.patch
          571 kB
          Raja Aluri
        2. ZOOKEEPER-1574.patch
          586 kB
          Michi Mutsuzaki
        3. ZOOKEEPER-1574.trunk.patch
          552 kB
          Raja Aluri

          Activity

            People

            • Assignee:
              raja@cmbasics.com Raja Aluri
              Reporter:
              raja@cmbasics.com Raja Aluri
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: