[ZOOKEEPER-1560] Zookeeper client hangs on creation of large nodes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.4, 3.5.0
• Fix Version/s: 3.4.5, 3.5.0
• Component/s: java client
• Hadoop Flags: Reviewed
• Assignee: Skye Wanderman-Milne
• Reporter: Igor Motov
• Created: 10/Oct/12 23:45
• Updated: 31/Oct/12 23:00
• Resolved: 31/Oct/12 18:44

Description

To reproduce, try creating a node with 0.5M of data using java client. The test will hang waiting for a response from the server. See the attached patch for the test that reproduces the issue.

It seems that ZOOKEEPER-1437 introduced a few issues to ClientCnxnSocketNIO.doIO that prevent ClientCnxnSocketNIO from sending large packets that require several invocations of SocketChannel.write to complete. The first issue is that the call to outgoingQueue.removeFirstOccurrence(p); removes the packet from the queue even if the packet wasn't completely sent yet. It looks to me that this call should be moved under if (!pbb.hasRemaining()) The second issue is that p.createBB() is reinitializing ByteBuffer on every iteration, which confuses SocketChannel.write. And the third issue is caused by extra calls to cnxn.getXid() that increment xid on every iteration and confuse the server.

Issue Links

• relates to: ZOOKEEPER-1561 Zookeeper client may hang on a server restart