Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.4.6
    • Fix Version/s: 3.4.6
    • Component/s: quorum
    • Labels:
      None

      Description

      Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state.

      1. ZOOKEEPER-1558.patch
        8 kB
        Flavio Junqueira
      2. ZOOKEEPER-1558.patch
        7 kB
        Flavio Junqueira
      3. ZOOKEEPER-1558.patch
        7 kB
        Flavio Junqueira
      4. ZOOKEEPER-1558.patch
        6 kB
        Thawan Kooburat
      5. ZOOKEEPER-1558.patch
        6 kB
        Flavio Junqueira
      6. ZOOKEEPER-1558.patch
        6 kB
        Flavio Junqueira
      7. ZOOKEEPER-1558.patch
        1 kB
        Flavio Junqueira
      8. ZOOKEEPER-1558.patch
        1 kB
        Flavio Junqueira

        Activity

        Hide
        Flavio Junqueira added a comment -

        Preliminary patch, it does not include a test.

        Show
        Flavio Junqueira added a comment - Preliminary patch, it does not include a test.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12548121/ZOOKEEPER-1558.patch
        against trunk revision 1391526.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1208//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1208//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1208//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12548121/ZOOKEEPER-1558.patch against trunk revision 1391526. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1208//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1208//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1208//console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        I'm sorry for not making progress with this patch before. I verified that the patch I proposed works with the case that Jacky007 posted. Since this is an issue that has been introduced with Zab1.0, I'd like to have it added to the Zab1_0Test tests, so I'm trying to rewrite the tests to comply with the general way we have been writing tests there. I should be able to post something soon.

        Show
        Flavio Junqueira added a comment - I'm sorry for not making progress with this patch before. I verified that the patch I proposed works with the case that Jacky007 posted. Since this is an issue that has been introduced with Zab1.0, I'd like to have it added to the Zab1_0Test tests, so I'm trying to rewrite the tests to comply with the general way we have been writing tests there. I should be able to post something soon.
        Hide
        Flavio Junqueira added a comment -

        Includes a test case.

        Show
        Flavio Junqueira added a comment - Includes a test case.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12552174/ZOOKEEPER-1558.patch
        against trunk revision 1404288.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1248//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1248//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1248//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12552174/ZOOKEEPER-1558.patch against trunk revision 1404288. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1248//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1248//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1248//console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        Great, this one has gone through fine. I would appreciate a review of this patch. I was also wondering if this should go to 3.4 branch too.

        Show
        Flavio Junqueira added a comment - Great, this one has gone through fine. I would appreciate a review of this patch. I was also wondering if this should go to 3.4 branch too.
        Hide
        Thawan Kooburat added a comment -
        • This is minor but you can make Zab1_0Test class extends ClientBase and use its createTmpDir() method instead of creating tmpDir manually.
        • Please update comments such as //Setup a database... and //Set the last.. to reflect what actually happen
        • Can we also test that the leader take snapshot when it have quorum of supported? Not sure if it is possible, but if we don't shutdown the leader at the end of the test and start a follower, then we should be able to test that code path.
        Show
        Thawan Kooburat added a comment - This is minor but you can make Zab1_0Test class extends ClientBase and use its createTmpDir() method instead of creating tmpDir manually. Please update comments such as //Setup a database... and //Set the last.. to reflect what actually happen Can we also test that the leader take snapshot when it have quorum of supported? Not sure if it is possible, but if we don't shutdown the leader at the end of the test and start a follower, then we should be able to test that code path.
        Hide
        Flavio Junqueira added a comment -

        Thanks for reviewing, Thawan.

        his is minor but you can make Zab1_0Test class extends ClientBase and use its createTmpDir() method instead of creating tmpDir manually.

        I'd rather do that in a separate jira, since it touches test cases that are unrelated to this issue.

        Please update comments such as //Setup a database... and //Set the last.. to reflect what actually happen

        Sure, will do.

        Can we also test that the leader take snapshot when it have quorum of supported? Not sure if it is possible, but if we don't shutdown the leader at the end of the test and start a follower, then we should be able to test that code path.

        I suppose you're talking about checking this:

        +            /*
        +             * Take snapshot once it has a quorum of followers supporting
        +             */
        +            zk.takeSnapshot();
        +            
        

        This snapshot is not strictly necessary for correctness, but it is convenient to do one at that point. I'd rather not extend the test case to verify it, since its addition does not affect correctness.

        Show
        Flavio Junqueira added a comment - Thanks for reviewing, Thawan. his is minor but you can make Zab1_0Test class extends ClientBase and use its createTmpDir() method instead of creating tmpDir manually. I'd rather do that in a separate jira, since it touches test cases that are unrelated to this issue. Please update comments such as //Setup a database... and //Set the last.. to reflect what actually happen Sure, will do. Can we also test that the leader take snapshot when it have quorum of supported? Not sure if it is possible, but if we don't shutdown the leader at the end of the test and start a follower, then we should be able to test that code path. I suppose you're talking about checking this: + /* + * Take snapshot once it has a quorum of followers supporting + */ + zk.takeSnapshot(); + This snapshot is not strictly necessary for correctness, but it is convenient to do one at that point. I'd rather not extend the test case to verify it, since its addition does not affect correctness.
        Hide
        Flavio Junqueira added a comment -

        Cancelling patch to address comments.

        Show
        Flavio Junqueira added a comment - Cancelling patch to address comments.
        Hide
        Thawan Kooburat added a comment -

        I agree that the current patch fix the problem on the leader side. However, I would like to see how do we plan to fix the whole problem first so we know that we moving in the right direction.

        Show
        Thawan Kooburat added a comment - I agree that the current patch fix the problem on the leader side. However, I would like to see how do we plan to fix the whole problem first so we know that we moving in the right direction.
        Hide
        Flavio Junqueira added a comment -

        Rebased patch.

        Show
        Flavio Junqueira added a comment - Rebased patch.
        Hide
        Flavio Junqueira added a comment -

        I think this patch should go only to 3.4.6. We will have a more comprehensive patch for 3.5.0 (ZOOKEEPER-1549).

        Show
        Flavio Junqueira added a comment - I think this patch should go only to 3.4.6. We will have a more comprehensive patch for 3.5.0 ( ZOOKEEPER-1549 ).
        Hide
        Flavio Junqueira added a comment -

        Is there anyone opposed to having the patch here committed only to 3.4.6 and having the more comprehensive fix of ZOOKEEPER-1549 to 3.50? The other option is to drop this jira and have ZOOKEEPER-1549 also committed to 3.4.6.

        Show
        Flavio Junqueira added a comment - Is there anyone opposed to having the patch here committed only to 3.4.6 and having the more comprehensive fix of ZOOKEEPER-1549 to 3.50? The other option is to drop this jira and have ZOOKEEPER-1549 also committed to 3.4.6.
        Hide
        Flavio Junqueira added a comment -

        I'd really like to either get a +1 here to commit it to 3.4.6 or a confirmation that we will also get ZK-1549 committed to 3.4.6. To provide some context, the fix of 3.5.0 has BC issues, check this comment by Thawan Kooburat:

        https://issues.apache.org/jira/browse/ZOOKEEPER-1549?focusedCommentId=13567348&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13567348

        Show
        Flavio Junqueira added a comment - I'd really like to either get a +1 here to commit it to 3.4.6 or a confirmation that we will also get ZK-1549 committed to 3.4.6. To provide some context, the fix of 3.5.0 has BC issues, check this comment by Thawan Kooburat : https://issues.apache.org/jira/browse/ZOOKEEPER-1549?focusedCommentId=13567348&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13567348
        Hide
        Flavio Junqueira added a comment -

        Thawan Kooburat, Could you please have a look at my comment right before this one?

        Show
        Flavio Junqueira added a comment - Thawan Kooburat , Could you please have a look at my comment right before this one?
        Hide
        Thawan Kooburat added a comment -

        I think the patch need to be rebased in order to apply.

        With the recent issue of ZOOKEEPER-1697, I am wondering if we need to revisit the solution. If I understand correctly, this patch move the snapshot step from pre-leader election to after synchronization and before broadcast phase. I believe we already transition to use syncLimit by the time we take this snapshot. I believe we should be taking snapshot while using initLimit

        In any case, we should add more comment about timing consideration into the patch as well.

        Show
        Thawan Kooburat added a comment - I think the patch need to be rebased in order to apply. With the recent issue of ZOOKEEPER-1697 , I am wondering if we need to revisit the solution. If I understand correctly, this patch move the snapshot step from pre-leader election to after synchronization and before broadcast phase. I believe we already transition to use syncLimit by the time we take this snapshot. I believe we should be taking snapshot while using initLimit In any case, we should add more comment about timing consideration into the patch as well.
        Hide
        Flavio Junqueira added a comment -

        You may be thinking about a different jira. This is one is not about long transfers, but about taking a snapshot at the wrong time, which causes us to include uncommitted state in the snapshot. This solution is not complete, but takes care of the scenario described originally in ZOOKEEPER-1549, which is supposed to go into 3.5.0 only (see discussion above).

        I'd like to come to a resolution for this jira, so I'd appreciate if you could either propose a different plan or review the patch, Thawan Kooburat.

        Show
        Flavio Junqueira added a comment - You may be thinking about a different jira. This is one is not about long transfers, but about taking a snapshot at the wrong time, which causes us to include uncommitted state in the snapshot. This solution is not complete, but takes care of the scenario described originally in ZOOKEEPER-1549 , which is supposed to go into 3.5.0 only (see discussion above). I'd like to come to a resolution for this jira, so I'd appreciate if you could either propose a different plan or review the patch, Thawan Kooburat .
        Hide
        Flavio Junqueira added a comment -

        Thawan Kooburat, could you please chime in here?

        Show
        Flavio Junqueira added a comment - Thawan Kooburat , could you please chime in here?
        Hide
        Thawan Kooburat added a comment -

        Again, my concern is that the current solution would cause leader to be blocked taking the snapshot before starting to send ping to quorum members. If the snapshot taking time is larger than syncLimit, the quorum will tear down. You can simply simulate this situation by adding sleep which is longer that syncLimit into the new code where takeSnaphot() is called.

        If we agree that this is any issue, a simple fix is to create a method that take snapshot asynchronously (spin up a thread on demand similar to SyncRequestProcessor). Some refactoring and additional locking may be needed as well in order to do this cleanly.

        Show
        Thawan Kooburat added a comment - Again, my concern is that the current solution would cause leader to be blocked taking the snapshot before starting to send ping to quorum members. If the snapshot taking time is larger than syncLimit, the quorum will tear down. You can simply simulate this situation by adding sleep which is longer that syncLimit into the new code where takeSnaphot() is called. If we agree that this is any issue, a simple fix is to create a method that take snapshot asynchronously (spin up a thread on demand similar to SyncRequestProcessor). Some refactoring and additional locking may be needed as well in order to do this cleanly.
        Hide
        Thawan Kooburat added a comment -

        Update a patch to make it apply cleanly with 3.4 branch

        Show
        Thawan Kooburat added a comment - Update a patch to make it apply cleanly with 3.4 branch
        Hide
        Flavio Junqueira added a comment -

        I was actually thinking about removing that call to takeSnapshot() from the leader so that we don't have the syncLimit problem you're referring to.

        Show
        Flavio Junqueira added a comment - I was actually thinking about removing that call to takeSnapshot() from the leader so that we don't have the syncLimit problem you're referring to.
        Hide
        Thawan Kooburat added a comment -

        Yeah, I think that should work as well. Seem like a new txnlog file is produced on a new epoch so that should be fine.

        I am wondering if we should apply this to 3.5 so at least the problem in 1549 is partially fixed in trunk as well before 1549 land and we also get more testing.

        Show
        Thawan Kooburat added a comment - Yeah, I think that should work as well. Seem like a new txnlog file is produced on a new epoch so that should be fine. I am wondering if we should apply this to 3.5 so at least the problem in 1549 is partially fixed in trunk as well before 1549 land and we also get more testing.
        Hide
        Flavio Junqueira added a comment -

        Ok, I'll produce a new patch for 3.4. I think it would be best to simply get ZOOKEEPER-1549 in. I've been ignoring it just because I'm focusing on the 3.4.6 release.

        Show
        Flavio Junqueira added a comment - Ok, I'll produce a new patch for 3.4. I think it would be best to simply get ZOOKEEPER-1549 in. I've been ignoring it just because I'm focusing on the 3.4.6 release.
        Hide
        Flavio Junqueira added a comment -

        I have removed the call to takeSnapshot(). When I did it, ZkDatabaseCorruptionTest started failing and I realized that there was a bug in the test case. We set snapCount to have servers taking a number of snapshots during the test. However, by the time we set snapCount to 100, randRoll has already been set and the values are typically much larger than the 2000 ops we are running. Consequently, we never have a snapshot.

        To fix it, I have changed SyncRequestProcessor to change the value of randRoll when we set snapCount. For the purposes of this test, I think this is sufficient.

        Show
        Flavio Junqueira added a comment - I have removed the call to takeSnapshot(). When I did it, ZkDatabaseCorruptionTest started failing and I realized that there was a bug in the test case. We set snapCount to have servers taking a number of snapshots during the test. However, by the time we set snapCount to 100, randRoll has already been set and the values are typically much larger than the 2000 ops we are running. Consequently, we never have a snapshot. To fix it, I have changed SyncRequestProcessor to change the value of randRoll when we set snapCount. For the purposes of this test, I think this is sufficient.
        Hide
        Flavio Junqueira added a comment -

        This patch is for the 3.4 branch, so I expect QA to fail.

        Show
        Flavio Junqueira added a comment - This patch is for the 3.4 branch, so I expect QA to fail.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12608368/ZOOKEEPER-1558.patch
        against trunk revision 1531444.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608368/ZOOKEEPER-1558.patch against trunk revision 1531444. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//console This message is automatically generated.
        Hide
        Thawan Kooburat added a comment -

        Minor style change request: please use "private static int randRoll ..." and move variable declaration to be on top of constructor (ideally below snapcount since it is a related variable)

        Other parts look good for me so +1 once style change is made

        Show
        Thawan Kooburat added a comment - Minor style change request: please use "private static int randRoll ..." and move variable declaration to be on top of constructor (ideally below snapcount since it is a related variable) Other parts look good for me so +1 once style change is made
        Hide
        Flavio Junqueira added a comment -

        Thanks for the review, Thawan Kooburat. I'm uploading a new patch.

        Show
        Flavio Junqueira added a comment - Thanks for the review, Thawan Kooburat . I'm uploading a new patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12609166/ZOOKEEPER-1558.patch
        against trunk revision 1533161.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1707//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1707//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1707//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12609166/ZOOKEEPER-1558.patch against trunk revision 1533161. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1707//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1707//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1707//console This message is automatically generated.
        Hide
        Thawan Kooburat added a comment -

        Thanks Flavio, the patch looks good to me

        Show
        Thawan Kooburat added a comment - Thanks Flavio, the patch looks good to me
        Hide
        Flavio Junqueira added a comment -

        Thanks, Thawan Kooburat. I made a small change to get rid of the findbugs warning.

        Show
        Flavio Junqueira added a comment - Thanks, Thawan Kooburat . I made a small change to get rid of the findbugs warning.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12609263/ZOOKEEPER-1558.patch
        against trunk revision 1533161.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1708//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1708//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1708//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12609263/ZOOKEEPER-1558.patch against trunk revision 1533161. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1708//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1708//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1708//console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        Committed revision 1533725.

        Show
        Flavio Junqueira added a comment - Committed revision 1533725.
        Hide
        Flavio Junqueira added a comment -

        Closing issues after releasing 3.4.6.

        Show
        Flavio Junqueira added a comment - Closing issues after releasing 3.4.6.

          People

          • Assignee:
            Flavio Junqueira
            Reporter:
            Flavio Junqueira
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development