[ZOOKEEPER-1522] intermittent failures in Zab test due to NPE in recursiveDelete test function

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.3, 3.5.0
• Fix Version/s: 3.4.4, 3.5.0
• Component/s: tests
• Hadoop Flags: Reviewed
• Assignee: Patrick D. Hunt
• Reporter: Patrick D. Hunt
• Created: 30/Jul/12 22:27
• Updated: 01/Aug/12 21:12
• Resolved: 01/Aug/12 15:57

Description

The jdk7 test job on jenkins is failing intermittently with

java.lang.NullPointerException
	at org.apache.zookeeper.server.quorum.Zab1_0Test.recursiveDelete(Zab1_0Test.java:917)
	at org.apache.zookeeper.server.quorum.Zab1_0Test.recursiveDelete(Zab1_0Test.java:918)
	at org.apache.zookeeper.server.quorum.Zab1_0Test.recursiveDelete(Zab1_0Test.java:918)
	at org.apache.zookeeper.server.quorum.Zab1_0Test.testPopulatedLeaderConversation(Zab1_0Test.java:419)
	at org.apache.zookeeper.server.quorum.Zab1_0Test.testUnnecessarySnap(Zab1_0Test.java:483)

Seems to not be handling the case where the file is deleted out from under. Also the recursive deletes should be at the very end of the finally I would think.