ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1520

A txn log record with a corrupt sentinel byte looks like EOF

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.3.5
    • Fix Version/s: 3.5.2, 3.6.0
    • Component/s: server
    • Labels:
    • Environment:

      all

      Description

      In Util.readTxnBytes() the sentinel is compared with 0x42 and if it does not match then the record is considered partially written and thus the EOF. However if it is a partial record the sentinel should be 0x00 since that is what the log is initialized with. Any other value would indicate corruption and should throw an IOException rather than indicate EOF. See ZOOKEEPER-1453 for a related issue.

      1. ant.out
        24 kB
        Bill Bridge
      2. checkout.out
        85 kB
        Bill Bridge
      3. init.out
        0.4 kB
        Bill Bridge
      4. init.out
        0.4 kB
        Bill Bridge
      5. ZOOKEEPER-1520.patch
        11 kB
        Bill Bridge

        Activity

        Michi Mutsuzaki made changes -
        Fix Version/s 3.5.2 [ 12331981 ]
        Fix Version/s 3.6.0 [ 12326518 ]
        Fix Version/s 3.4.7 [ 12325149 ]
        Fix Version/s 3.5.1 [ 12326786 ]
        Patrick Hunt made changes -
        Fix Version/s 3.5.1 [ 12326786 ]
        Fix Version/s 3.5.0 [ 12316644 ]
        Michi Mutsuzaki made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Patrick Hunt made changes -
        Fix Version/s 3.4.7 [ 12325149 ]
        Fix Version/s 3.5.0 [ 12316644 ]
        Fix Version/s 3.3.6 [ 12320172 ]
        Flavio Junqueira made changes -
        Assignee Bill Bridge [ bbridge ]
        Bill Bridge made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Bill Bridge made changes -
        Attachment ZOOKEEPER-1520.patch [ 12541774 ]
        Bill Bridge made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Bill Bridge made changes -
        Attachment ZOOKEEPER-1520.patch [ 12542370 ]
        Bill Bridge made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Labels newbie newbie patch
        Fix Version/s 3.3.6 [ 12320172 ]
        Bill Bridge made changes -
        Attachment ZOOKEEPER-1520.patch [ 12541774 ]
        Bill Bridge made changes -
        Attachment checkout.out [ 12539727 ]
        Attachment ant.out [ 12539728 ]
        Bill Bridge made changes -
        Attachment init.out [ 12539726 ]
        Bill Bridge made changes -
        Field Original Value New Value
        Attachment init.out [ 12539722 ]
        Bill Bridge created issue -

          People

          • Assignee:
            Bill Bridge
            Reporter:
            Bill Bridge
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development