Hadoop QA added a comment - 31/Jul/12 23:09 -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12535121/fix_always_OK_when_cannot_connect_to_zookeeper.patch against trunk revision 1366784. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1149//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1149//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1149//console This message is automatically generated.

Mahadev konar added a comment - 07/Sep/12 06:30 Patch looks good. I just committed it to trunk and 3.4 branch. Thanks Brian!

Hudson added a comment - 07/Sep/12 11:01 Integrated in ZooKeeper-trunk #1672 (See https://builds.apache.org/job/ZooKeeper-trunk/1672/ ) ZOOKEEPER-1501 . Nagios plugin always returns OK when it cannot connect to zookeeper. (Brian Sutherland via mahadev) (Revision 1381902) Result = SUCCESS mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381902 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/contrib/monitoring/check_zookeeper.py