ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1494

C client: socket leak after receive timeout in zookeeper_interest()

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.2, 3.3.5
    • Fix Version/s: 3.4.4, 3.5.0
    • Component/s: c client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In zookeeper_interest(), we set zk->fd to -1 without closing it when timeout happens. Instead we should let handle_socket_error_msg() function take care of closing the socket properly.

      --Michi

      1. ZOOKEEPER-1494.patch
        0.8 kB
        Michi Mutsuzaki
      2. ZOOKEEPER-1494-3.4.patch
        0.8 kB
        Michi Mutsuzaki
      3. ZOOKEEPER-1494.patch
        0.8 kB
        Mahadev konar

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        23m 18s 1 Michi Mutsuzaki 22/Jun/12 21:19
        In Progress In Progress Patch Available Patch Available
        43s 1 Michi Mutsuzaki 22/Jun/12 21:20
        Patch Available Patch Available Open Open
        17d 8h 20m 2 Mahadev konar 09/Sep/12 19:26
        Open Open Patch Available Patch Available
        61d 13h 46m 2 Mahadev konar 09/Sep/12 19:26
        Patch Available Patch Available Resolved Resolved
        12h 37m 1 Mahadev konar 10/Sep/12 08:04
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1675 (See https://builds.apache.org/job/ZooKeeper-trunk/1675/)
        ZOOKEEPER-1494. C client: socket leak after receive timeout in zookeeper_interest() (Michi Mutsuzaki via mahadev) (Revision 1382661)

        Result = SUCCESS
        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1382661
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/c/src/zookeeper.c
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1675 (See https://builds.apache.org/job/ZooKeeper-trunk/1675/ ) ZOOKEEPER-1494 . C client: socket leak after receive timeout in zookeeper_interest() (Michi Mutsuzaki via mahadev) (Revision 1382661) Result = SUCCESS mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1382661 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/c/src/zookeeper.c
        Mahadev konar made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Hide
        Mahadev konar added a comment -

        Thanks Michi. I committed the patch to trunk and 3.4 branch.

        Show
        Mahadev konar added a comment - Thanks Michi. I committed the patch to trunk and 3.4 branch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12544406/ZOOKEEPER-1494.patch
        against trunk revision 1382555.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1180//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1180//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1180//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544406/ZOOKEEPER-1494.patch against trunk revision 1382555. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1180//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1180//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1180//console This message is automatically generated.
        Mahadev konar made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Mahadev konar added a comment -

        Reattaching the trunk patch to get it through hudson again.

        Show
        Mahadev konar added a comment - Reattaching the trunk patch to get it through hudson again.
        Mahadev konar made changes -
        Attachment ZOOKEEPER-1494.patch [ 12544406 ]
        Mahadev konar made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Mahadev konar added a comment -

        Running through hudson again.

        Show
        Mahadev konar added a comment - Running through hudson again.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12543145/ZOOKEEPER-1494-3.4.patch
        against trunk revision 1379046.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1174//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1174//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1174//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12543145/ZOOKEEPER-1494-3.4.patch against trunk revision 1379046. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1174//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1174//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1174//console This message is automatically generated.
        Michi Mutsuzaki made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Michi Mutsuzaki made changes -
        Fix Version/s 3.3.7 [ 12321882 ]
        Michi Mutsuzaki made changes -
        Attachment ZOOKEEPER-1494.patch [ 12533101 ]
        Michi Mutsuzaki made changes -
        Attachment ZOOKEEPER-1494-3.4.patch [ 12543145 ]
        Patrick Hunt made changes -
        Fix Version/s 3.3.7 [ 12321882 ]
        Fix Version/s 3.3.6 [ 12320172 ]
        Michi Mutsuzaki made changes -
        Attachment ZOOKEEPER-1493_3_4.patch [ 12534133 ]
        Michi Mutsuzaki made changes -
        Attachment ZOOKEEPER-1493_3_3.patch [ 12534132 ]
        Michi Mutsuzaki made changes -
        Attachment ZOOKEEPER-1493_3_3.patch [ 12534132 ]
        Attachment ZOOKEEPER-1493_3_4.patch [ 12534133 ]
        Patrick Hunt made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Mahadev konar added a comment -

        Also a 3.4 patch.

        Show
        Mahadev konar added a comment - Also a 3.4 patch.
        Hide
        Mahadev konar added a comment -

        Mitchi,
        The patch looks good to me but can you upload a 3.3 patch for it? Thanks

        Show
        Mahadev konar added a comment - Mitchi, The patch looks good to me but can you upload a 3.3 patch for it? Thanks
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12533104/ZOOKEEPER-1494.patch
        against trunk revision 1351541.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1110//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1110//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1110//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533104/ZOOKEEPER-1494.patch against trunk revision 1351541. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1110//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1110//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1110//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12533101/ZOOKEEPER-1494.patch
        against trunk revision 1351541.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1109//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1109//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1109//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533101/ZOOKEEPER-1494.patch against trunk revision 1351541. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1109//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1109//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1109//console This message is automatically generated.
        Michi Mutsuzaki made changes -
        Attachment ZOOKEEPER-1494.patch [ 12533104 ]
        Hide
        Michi Mutsuzaki added a comment -

        Added the server name in the timeout log message.

        Show
        Michi Mutsuzaki added a comment - Added the server name in the timeout log message.
        Michi Mutsuzaki made changes -
        Summary C lient: socket leak after receive timeout in zookeeper_interest() C client: socket leak after receive timeout in zookeeper_interest()
        Michi Mutsuzaki made changes -
        Status In Progress [ 3 ] Patch Available [ 10002 ]
        Michi Mutsuzaki made changes -
        Attachment ZOOKEEPER-1494.patch [ 12533101 ]
        Michi Mutsuzaki made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Michi Mutsuzaki created issue -

          People

          • Assignee:
            Michi Mutsuzaki
            Reporter:
            Michi Mutsuzaki
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development