ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1490

If the configured log directory does not exist zookeeper will not start. Better to create the directory and start

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.4, 3.5.0
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      if the configured log directory does not exists zookeeper will not start. Better to create the directory and start
      in zkEnv.sh we can change as follows

      if [ "x$

      {ZOO_LOG_DIR}

      " = "x" ]
      then
      ZOO_LOG_DIR="."
      else
      if [ ! -w "$ZOO_LOG_DIR" ] ; then
      mkdir -p "$ZOO_LOG_DIR"
      fi
      fi

      1. ZOOKEEPER_1490_updated.patch
        0.4 kB
        suja s
      2. ZOOKEEPER_1490.patch
        0.4 kB
        suja s
      3. ZOOKEEPER_1490.patch
        0.3 kB
        suja s

        Activity

        Hide
        suja s added a comment -

        Attaching patch

        Show
        suja s added a comment - Attaching patch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12532506/ZOOKEEPER_1490.patch
        against trunk revision 1351541.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1098//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12532506/ZOOKEEPER_1490.patch against trunk revision 1351541. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1098//console This message is automatically generated.
        Hide
        Rakesh R added a comment -

        @Suja

        -1 patch. The patch command could not apply the patch.

        Here the patch has been generated directly from the modified file, instead please generate patch from the zk home.

        Please visit the following link for more understanding:
        http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute

        Show
        Rakesh R added a comment - @Suja -1 patch. The patch command could not apply the patch. Here the patch has been generated directly from the modified file, instead please generate patch from the zk home. Please visit the following link for more understanding: http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute
        Hide
        suja s added a comment -

        Attaching the updated patch

        Show
        suja s added a comment - Attaching the updated patch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12532511/ZOOKEEPER_1490.patch
        against trunk revision 1351541.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1099//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1099//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1099//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12532511/ZOOKEEPER_1490.patch against trunk revision 1351541. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1099//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1099//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1099//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        Creation of the log directory itself should not go into the env file, rather it should be in the scripts that may need a log dir (notice we don't do filesystem operations in env currently, just in server.sh etc...)

        Show
        Patrick Hunt added a comment - Creation of the log directory itself should not go into the env file, rather it should be in the scripts that may need a log dir (notice we don't do filesystem operations in env currently, just in server.sh etc...)
        Hide
        suja s added a comment -

        Thank You for taking a look. Attaching updated patch.

        Show
        suja s added a comment - Thank You for taking a look. Attaching updated patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12532854/ZOOKEEPER_1490_updated.patch
        against trunk revision 1351541.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1105//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1105//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1105//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12532854/ZOOKEEPER_1490_updated.patch against trunk revision 1351541. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1105//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1105//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1105//console This message is automatically generated.
        Hide
        Roman Shaposhnik added a comment -

        Looks good to me.

        Show
        Roman Shaposhnik added a comment - Looks good to me.
        Hide
        Patrick Hunt added a comment -

        Thanks for the submission Suja!

        Show
        Patrick Hunt added a comment - Thanks for the submission Suja!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1600 (See https://builds.apache.org/job/ZooKeeper-trunk/1600/)
        ZOOKEEPER-1490. If the configured log directory does not exist zookeeper will not start. Better to create the directory and start (suja s via phunt) (Revision 1355641)

        Result = SUCCESS
        phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355641
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/bin/zkServer.sh
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1600 (See https://builds.apache.org/job/ZooKeeper-trunk/1600/ ) ZOOKEEPER-1490 . If the configured log directory does not exist zookeeper will not start. Better to create the directory and start (suja s via phunt) (Revision 1355641) Result = SUCCESS phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355641 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/bin/zkServer.sh

          People

          • Assignee:
            suja s
            Reporter:
            suja s
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development