ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1481

allow the C cli to run exists with a watcher

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.3
    • Fix Version/s: 3.4.4, 3.5.0
    • Component/s: c client
    • Labels:
      None

      Description

      Adds a wexists command and also improves the stdout (type string rather than just the number). Granted wexists is more for testing purposes than strictly necessary (we have exists already) but but still worthwhile to add imo.

        Activity

        Hide
        Patrick Hunt added a comment -

        tested manually on the command line.

        Show
        Patrick Hunt added a comment - tested manually on the command line.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12531467/ZOOKEEPER-1481.patch
        against trunk revision 1337029.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1090//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1090//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1090//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12531467/ZOOKEEPER-1481.patch against trunk revision 1337029. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1090//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1090//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1090//console This message is automatically generated.
        Hide
        Michi Mutsuzaki added a comment -

        +1. I'll commit this to trunk and 3.4 branch.

        Thanks!
        --Michi

        Show
        Michi Mutsuzaki added a comment - +1. I'll commit this to trunk and 3.4 branch. Thanks! --Michi
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1665 (See https://builds.apache.org/job/ZooKeeper-trunk/1665/)
        ZOOKEEPER-1481 allow the C cli to run exists with a watcher (phunt via michim) (Revision 1379123)

        Result = SUCCESS
        michim : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379123
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/c/src/cli.c
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1665 (See https://builds.apache.org/job/ZooKeeper-trunk/1665/ ) ZOOKEEPER-1481 allow the C cli to run exists with a watcher (phunt via michim) (Revision 1379123) Result = SUCCESS michim : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379123 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/c/src/cli.c

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development