ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1480

ClientCnxn(1161) can't get the current zk server add, so that - Session 0x for server null, unexpected error

    Details

    • Tags:
      client,zookeeper addr,server

      Description

        When zookeeper occur an unexpected error( Not SessionExpiredException, SessionTimeoutException and EndOfStreamException), ClientCnxn(1161) will log such as the formart "Session 0x for server null, unexpected error, closing socket connection and attempting reconnect ". The log at line 1161 in zookeeper-3.3.3
        We found that, zookeeper use "((SocketChannel)sockKey.channel()).socket().getRemoteSocketAddress()" to get zookeeper addr. But,Sometimes, it logs "Session 0x for server null", you know, if log null, developer can't determine the current zookeeper addr that client is connected or connecting.
        I add a method in Class SendThread:InetSocketAddress org.apache.zookeeper.ClientCnxn.SendThread.getCurrentZooKeeperAddr().

        Here:
      /**

      • Returns the address to which the socket is connected.
      • @return ip address of the remote side of the connection or null if not
      • connected
        */
        @Override
        SocketAddress getRemoteSocketAddress() {
        // a lot could go wrong here, so rather than put in a bunch of code
        // to check for nulls all down the chain let's do it the simple
        // yet bulletproof way
        .....

        Activity

        Hide
        Patrick Hunt added a comment -

        Leader Ni can you update the patch and resubmit? Thanks!

        Show
        Patrick Hunt added a comment - Leader Ni can you update the patch and resubmit? Thanks!
        Hide
        Patrick Hunt added a comment -

        Cancelling while the patch is being updated.

        Show
        Patrick Hunt added a comment - Cancelling while the patch is being updated.
        Hide
        Mahadev konar added a comment -

        Hey Leader,
        There are quite a few chinese characters in the patch. Can you please remove those? Also, can you please create a patch against trunk?

        Thanks

        Show
        Mahadev konar added a comment - Hey Leader, There are quite a few chinese characters in the patch. Can you please remove those? Also, can you please create a patch against trunk? Thanks
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12552006/getCurrentZooKeeperAddr_for_3.4.3.patch
        against trunk revision 1422473.

        -1 @author. The patch appears to contain 1 @author tags which the Zookeeper community has agreed to not allow in code contributions.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1299//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12552006/getCurrentZooKeeperAddr_for_3.4.3.patch against trunk revision 1422473. -1 @author. The patch appears to contain 1 @author tags which the Zookeeper community has agreed to not allow in code contributions. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1299//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12552006/getCurrentZooKeeperAddr_for_3.4.3.patch
        against trunk revision 1404288.

        -1 @author. The patch appears to contain 1 @author tags which the Zookeeper community has agreed to not allow in code contributions.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1247//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12552006/getCurrentZooKeeperAddr_for_3.4.3.patch against trunk revision 1404288. -1 @author. The patch appears to contain 1 @author tags which the Zookeeper community has agreed to not allow in code contributions. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1247//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12531207/getCurrentZooKeeperAddr_for_trunk.patch
        against trunk revision 1337029.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1089//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1089//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1089//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12531207/getCurrentZooKeeperAddr_for_trunk.patch against trunk revision 1337029. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1089//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1089//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1089//console This message is automatically generated.
        Hide
        Leader Ni added a comment -

        Patch for trunk and branch 3.4 is substantially the same.But patch for 3.3.3 is different, since no StaticHostProvider in zookeeper-3.3.3

        Show
        Leader Ni added a comment - Patch for trunk and branch 3.4 is substantially the same.But patch for 3.3.3 is different, since no StaticHostProvider in zookeeper-3.3.3
        Hide
        Patrick Hunt added a comment -

        Hi Leader, it's unlikely this would go into 3.3 branch.

        The automated testing runs patches against trunk only. Please provide a patch for trunk (you might also need to provide a patch against branch-3.4 if it doesn't apply cleanly to both). Thanks!

        Show
        Patrick Hunt added a comment - Hi Leader, it's unlikely this would go into 3.3 branch. The automated testing runs patches against trunk only. Please provide a patch for trunk (you might also need to provide a patch against branch-3.4 if it doesn't apply cleanly to both). Thanks!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12531055/getCurrentZooKeeperAddr.patch
        against trunk revision 1337029.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1088//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12531055/getCurrentZooKeeperAddr.patch against trunk revision 1337029. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1088//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12531055/getCurrentZooKeeperAddr.patch
        against trunk revision 1337029.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1087//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12531055/getCurrentZooKeeperAddr.patch against trunk revision 1337029. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1087//console This message is automatically generated.

          People

          • Assignee:
            Leader Ni
            Reporter:
            Leader Ni
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:

              Development