ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1473

Committed proposal log retains triple the memory it needs to

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 3.5.0
    • Component/s: server
    • Labels:
      None

      Description

      ZKDatabase.committedLog retains the past 500 transactions to enable fast catch-up. This works great, but it's using triple the memory it needs to by retaining three copies of the data part of any transaction.

      • The first is in committedLog[i].request.request.hb - a heap-allocated ByteBuffer.
      • The second is in committedLog[i].request.txn.data - a jute-serialised record of the transaction
      • The third is in committedLog[i].packet.data - also jute-serialised, seemingly uninitialised data.

      This means that a ZK-server could be using 1G of memory more than it should be in the worst case. We should use just one copy of the data, even if we really have to refer to it 3 times.

      1. ZOOKEEPER-1473.patch
        2 kB
        Michi Mutsuzaki
      2. ZOOKEEPER-1473.patch
        2 kB
        Thawan Kooburat
      3. ZOOKEEPER-1473.patch
        2 kB
        Thawan Kooburat

        Activity

          People

          • Assignee:
            Thawan Kooburat
            Reporter:
            Henry Robinson
          • Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:

              Development