Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-1463

external inline function is not compatible with C99

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Duplicate
    • 3.4.3, 3.3.5
    • 3.4.4, 3.5.0
    • build
    • debian linux x64

    Description

      There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.

      hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
      function 'hashtable_iterator_key' which is not static

      The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
      #pragma GCC diagnostic ignored "-Winline"

      Attachments

        1. zookeeper-1463_1339.patch
          1 kB
          Michael Hu

        Activity

          People

            pwp Michael Hu
            pwp Michael Hu
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 0.1h
                0.1h
                Remaining:
                Remaining Estimate - 0.1h
                0.1h
                Logged:
                Time Spent - Not Specified
                Not Specified