[ZOOKEEPER-1463] external inline function is not compatible with C99

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 3.4.3, 3.3.5
• Fix Version/s: 3.4.4, 3.5.0
• Component/s: build
• Labels: external inline

Environment

debian linux x64

• Assignee: Michael Hu
• Reporter: Michael Hu
• Created: 07/May/12 21:52
• Updated: 11/May/12 05:26
• Resolved: 11/May/12 05:26

Description

There is a use of external inline function in zookeeper hashtable_itr.h file, which is not compatible with C99. This causes problem when compiling with other library like code coverage library.
—
hashtable_itr.h:37: error: 'cov_v_cab2c78b' is static but used in inline
function 'hashtable_iterator_key' which is not static
—

The easy fix would be put the following line in hashtable_itr.c which ignores this inline warning.
#pragma GCC diagnostic ignored "-Winline"