[ZOOKEEPER-1451] C API improperly logs getaddrinfo failures on Linux when using glibc

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.4.3
• Fix Version/s: 3.5.0
• Component/s: c client

Environment

Linux when using glibc

• Assignee: Stephen Tyree
• Reporter: Stephen Tyree
• Created: 19/Apr/12 18:04
• Updated: 25/Apr/12 20:29
• Resolved: 25/Apr/12 20:29

Description

This is how the code currently logs getaddrinfo errors:

errno = getaddrinfo_errno(rc);
LOG_ERROR(("getaddrinfo: %s\n", strerror(errno)));

On Linux, specifically when using glibc, there is a better function for logging getaddrinfo errors called gai_strerror. An example:

LOG_ERROR(("getaddrinfo: %s\n", gai_strerror(rc)));

It doesn't miss a lot of cases like the errno based version does.