Details

    • Type: Task Task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.4.4, 3.5.0
    • Fix Version/s: 3.4.6, 3.5.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Infra is phasing out the current mechanism we use to deploy maven artifacts. We need to move to repository.apache.org (nexus).

      In particular we need to ensure the following artifacts get published:

      • zookeeper-3.x.y.jar
      • zookeeper-3.x.y-sources.jar
      • zookeeper-3.x.y-tests.jar
      • zookeeper-3.x.y-javadoc.jar

      In 3.4.4/3.4.5 we missed the tests jar which caused headaches for downstream users, such as Hadoop.

      1. ZOOKEEPER-1430.patch
        6 kB
        Patrick Hunt
      2. ZOOKEEPER-1430.patch
        4 kB
        Patrick Hunt
      3. ZOOKEEPER-1430-3.4.6-v4.patch
        12 kB
        Giridharan Kesavan
      4. ZOOKEEPER-1430-3.4.6-v5.patch
        11 kB
        Giridharan Kesavan
      5. ZOOKEEPER-1430-3.4.6-v6.patch
        10 kB
        Giridharan Kesavan
      6. ZOOKEEPER-1430-3.4.patch
        5 kB
        Mahadev konar
      7. ZOOKEEPER-1430-3.5.0-v4.patch
        12 kB
        Giridharan Kesavan
      8. ZOOKEEPER-1430-3.5.0-v5.patch
        11 kB
        Giridharan Kesavan
      9. ZOOKEEPER-1430-3.5.0-v6.patch
        10 kB
        Giridharan Kesavan
      10. ZOOKEEPER-1430-br34-V3.patch
        12 kB
        Patrick Hunt
      11. ZOOKEEPER-1430-V1.PATCH
        13 kB
        Giridharan Kesavan
      12. ZOOKEEPER-1430-V2.PATCH
        14 kB
        Giridharan Kesavan
      13. ZOOKEEPER-1430-V3.patch
        12 kB
        Giridharan Kesavan

        Issue Links

          Activity

          Patrick Hunt created issue -
          Hide
          Patrick Hunt added a comment -

          initial attempt.

          Show
          Patrick Hunt added a comment - initial attempt.
          Patrick Hunt made changes -
          Field Original Value New Value
          Attachment ZOOKEEPER-1430.patch [ 12519469 ]
          Patrick Hunt made changes -
          Link This issue is blocked by INFRA-4565 [ INFRA-4565 ]
          Hide
          Patrick Hunt added a comment -

          This latest version of the patch was used to push 3.3.6 to r.a.o. (afaict successfully).

          Show
          Patrick Hunt added a comment - This latest version of the patch was used to push 3.3.6 to r.a.o. (afaict successfully).
          Patrick Hunt made changes -
          Attachment ZOOKEEPER-1430.patch [ 12539105 ]
          Hide
          Mahadev konar added a comment -

          Patch for uploading artifacts that works on the 3.4 branch. Had to tweak it a little to get it to work on 3.4 branch. Thanks Pat!

          Show
          Mahadev konar added a comment - Patch for uploading artifacts that works on the 3.4 branch. Had to tweak it a little to get it to work on 3.4 branch. Thanks Pat!
          Mahadev konar made changes -
          Attachment ZOOKEEPER-1430-3.4.patch [ 12546231 ]
          Hide
          Giridharan Kesavan added a comment -

          Patrick,

          This v1 patch uses maven-ant-task to publish artifacts to snapshot/staging repo based on the args.

          ant mvn-deploy -Dstaging=true
          

          upload artifact's to the apache nexus stating repo. with gpg signing, it would ask you for your gpg key password to sign the artifact.

          ant mvn-deploy
          

          this would upload artifact's to the apache snapshot repo. without signing.

          Show
          Giridharan Kesavan added a comment - Patrick, This v1 patch uses maven-ant-task to publish artifacts to snapshot/staging repo based on the args. ant mvn-deploy -Dstaging=true upload artifact's to the apache nexus stating repo. with gpg signing, it would ask you for your gpg key password to sign the artifact. ant mvn-deploy this would upload artifact's to the apache snapshot repo. without signing.
          Giridharan Kesavan made changes -
          Attachment ZOOKEEPER-1430-V1.PATCH [ 12571270 ]
          Hide
          Giridharan Kesavan added a comment -

          remove the duplicate checksum's

          Show
          Giridharan Kesavan added a comment - remove the duplicate checksum's
          Giridharan Kesavan made changes -
          Attachment ZOOKEEPER-1430-V2.PATCH [ 12572460 ]
          Hide
          Patrick Hunt added a comment -

          We need to get this into the build in order to publish to the maven repo as part of the release process.

          We should push to staging as part of the voting process, then release after the vote succeeds.

          Show
          Patrick Hunt added a comment - We need to get this into the build in order to publish to the maven repo as part of the release process. We should push to staging as part of the voting process, then release after the vote succeeds.
          Patrick Hunt made changes -
          Fix Version/s 3.4.6 [ 12323310 ]
          Fix Version/s 3.5.0 [ 12316644 ]
          Priority Major [ 3 ] Blocker [ 1 ]
          Patrick Hunt made changes -
          Description Infra is phasing out the current mechanism we use to deploy maven artifacts. We need to move to repository.apache.org (nexus). Infra is phasing out the current mechanism we use to deploy maven artifacts. We need to move to repository.apache.org (nexus).

          In particular we need to ensure the following artifacts get published:
          * zookeeper-3.x.y.jar
          * zookeeper-3.x.y-sources.jar
          * zookeeper-3.x.y-tests.jar
          * zookeeper-3.x.y-javadoc.jar

          In 3.4.4/3.4.5 we missed the tests jar which caused headaches for downstream users, such as Hadoop.
          Patrick Hunt made changes -
          Link This issue is related to ZOOKEEPER-1686 [ ZOOKEEPER-1686 ]
          Hide
          Patrick Hunt added a comment -

          ZOOKEEPER-1686 had issues due to earlier versions of this patch. We need to ensure the proper artifacts are published as part of the release. We need to stage the artifacts to nexus, then review, then release.

          Show
          Patrick Hunt added a comment - ZOOKEEPER-1686 had issues due to earlier versions of this patch. We need to ensure the proper artifacts are published as part of the release. We need to stage the artifacts to nexus, then review, then release.
          Hide
          Patrick Hunt added a comment -

          Giridharan Kesavan any chance you could update the instructions on the HowToRelease page?

          https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease

          Show
          Patrick Hunt added a comment - Giridharan Kesavan any chance you could update the instructions on the HowToRelease page? https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease
          Hide
          Patrick Hunt added a comment -

          Giridharan Kesavan am I right in thinking this can be tested at any time (staging), e.g. prior to committing for instance. We'd just drop the tests prior to the release? Can you shed more light.

          Show
          Patrick Hunt added a comment - Giridharan Kesavan am I right in thinking this can be tested at any time (staging), e.g. prior to committing for instance. We'd just drop the tests prior to the release? Can you shed more light.
          Hide
          Giridharan Kesavan added a comment -

          Patrick Hunt I have figured a much better way of dealing with the gpg password using mvn settings.xml. Let me get back to you in a day or two with that patch, this would simplify on how we publish artifacts to nexus.

          Show
          Giridharan Kesavan added a comment - Patrick Hunt I have figured a much better way of dealing with the gpg password using mvn settings.xml. Let me get back to you in a day or two with that patch, this would simplify on how we publish artifacts to nexus.
          Hide
          Patrick Hunt added a comment -

          Cool. Thanks Giri!

          Show
          Patrick Hunt added a comment - Cool. Thanks Giri!
          Hide
          Patrick Hunt added a comment -

          I've updated the https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease page with placeholders for deploying/releasing the artifacts.

          Show
          Patrick Hunt added a comment - I've updated the https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease page with placeholders for deploying/releasing the artifacts.
          Patrick Hunt made changes -
          Affects Version/s 3.4.4 [ 12319841 ]
          Affects Version/s 3.5.0 [ 12316644 ]
          Hide
          Patrick Hunt added a comment -

          Giridharan Kesavan any update on this?

          Show
          Patrick Hunt added a comment - Giridharan Kesavan any update on this?
          Patrick Hunt made changes -
          Assignee Patrick Hunt [ phunt ] Giridharan Kesavan [ gkesavan ]
          Hide
          Flavio Junqueira added a comment -

          Should I start worrying about this jira now, Patrick Hunt, Giridharan Kesavan, Mahadev konar? We are getting close to being able to cut a 3.4.6 RC.

          Show
          Flavio Junqueira added a comment - Should I start worrying about this jira now, Patrick Hunt , Giridharan Kesavan , Mahadev konar ? We are getting close to being able to cut a 3.4.6 RC.
          Hide
          Giridharan Kesavan added a comment -

          I'm on it.

          Show
          Giridharan Kesavan added a comment - I'm on it.
          Hide
          Patrick Hunt added a comment -

          Flavio Junqueira you need this patch in order to publish the maven release artifacts as part of the RC cutting, w/o this none of the downstream users (hadoop, hbase, curator, etc...) will be able to consume it.

          Show
          Patrick Hunt added a comment - Flavio Junqueira you need this patch in order to publish the maven release artifacts as part of the RC cutting, w/o this none of the downstream users (hadoop, hbase, curator, etc...) will be able to consume it.
          Hide
          Giridharan Kesavan added a comment -

          this v3 patch user gpg profile to get the gpg.passphrase for signing the artifact when uploading to staging.
          Details below:

          ant mvn-deploy

          • this deploys the snapshot artifact to the nexus snapshot repository
          • expects jar files has -SNAPSHOT suffix present in it.

          ant mvn-deploy -Dstaging=true

          • Essentially this is done when an Release Candidate is pushed.
          • This target deploy's release versioned artifact to the nexus staging profile
          • For staging the artifacts, staging repo requires the artifacts be signed using gpg keys.
          • To sign the artifact using gpg keys , one has to provide the gpg passphrase in plain text in the ~/.m2/settings.xml
            If one is worried about leaving plain text password, they can refer to http://maven.apache.org/guides/mini/guide-encryption.html for encrypting the passphrase.

          Here is the ~/.m2/settings.xml that I used for testing the targets above.

          <settings>
            <servers>
              <server>
                <id>apache.snapshots.https</id>
                <username>XXXXXXX</username>
                <password>XXXXXXXX</password>
              </server>
              <server>
                <id>apache.staging.https</id>
                <username>XXXXXXX</username>
                <password>XXXXXXX</password>
              </server>
            </servers>
            <profiles>
              <profile>
                <id>gpg</id>
                <properties>
                  <gpg.passphrase>XXXXXXX</gpg.passphrase>
                </properties>
              </profile>
            </profiles>
          </settings>
          
          Show
          Giridharan Kesavan added a comment - this v3 patch user gpg profile to get the gpg.passphrase for signing the artifact when uploading to staging. Details below: ant mvn-deploy this deploys the snapshot artifact to the nexus snapshot repository expects jar files has -SNAPSHOT suffix present in it. ant mvn-deploy -Dstaging=true Essentially this is done when an Release Candidate is pushed. This target deploy's release versioned artifact to the nexus staging profile For staging the artifacts, staging repo requires the artifacts be signed using gpg keys. To sign the artifact using gpg keys , one has to provide the gpg passphrase in plain text in the ~/.m2/settings.xml If one is worried about leaving plain text password, they can refer to http://maven.apache.org/guides/mini/guide-encryption.html for encrypting the passphrase. Here is the ~/.m2/settings.xml that I used for testing the targets above. <settings> <servers> <server> <id> apache.snapshots.https </id> <username> XXXXXXX </username> <password> XXXXXXXX </password> </server> <server> <id> apache.staging.https </id> <username> XXXXXXX </username> <password> XXXXXXX </password> </server> </servers> <profiles> <profile> <id> gpg </id> <properties> <gpg.passphrase> XXXXXXX </gpg.passphrase> </properties> </profile> </profiles> </settings>
          Giridharan Kesavan made changes -
          Attachment ZOOKEEPER-1430-V3.patch [ 12610422 ]
          Hide
          Patrick Hunt added a comment -

          Giridharan Kesavan I applied the patch to 3.4 branch (minor conflict, see attachment) but it fails when running mvn-deploy as follows: (I did not try running with trunk)

          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [ERROR] BUILD FAILURE
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [INFO] Invalid task '': you must specify a valid lifecycle phase, or a goal in the format plugin:goal or pluginGroupId:pluginArtifactId:pluginVersion:goal
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [INFO] For more information, run Maven with the -e switch
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [INFO] Total time: 50 seconds
          [artifact:mvn] [INFO] Finished at: Sat Nov 02 08:30:38 PDT 2013
          [artifact:mvn] [INFO] Final Memory: 32M/351M
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] Java Result: 1
          [artifact:mvn] [INFO] Scanning for projects...
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [ERROR] BUILD FAILURE
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [INFO] Invalid task '': you must specify a valid lifecycle phase, or a goal in the format plugin:goal or pluginGroupId:pluginArtifactId:pluginVersion:goal
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [INFO] For more information, run Maven with the -e switch
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [INFO] Total time: < 1 second
          [artifact:mvn] [INFO] Finished at: Sat Nov 02 08:30:39 PDT 2013
          [artifact:mvn] [INFO] Final Memory: 32M/352M
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] Java Result: 1
          [artifact:mvn] [INFO] Scanning for projects...
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [ERROR] BUILD FAILURE
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [INFO] Invalid task '': you must specify a valid lifecycle phase, or a goal in the format plugin:goal or pluginGroupId:pluginArtifactId:pluginVersion:goal
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [INFO] For more information, run Maven with the -e switch
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [INFO] Total time: < 1 second
          [artifact:mvn] [INFO] Finished at: Sat Nov 02 08:30:40 PDT 2013
          [artifact:mvn] [INFO] Final Memory: 33M/352M
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] Java Result: 1
          [artifact:mvn] [INFO] Scanning for projects...
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [ERROR] BUILD FAILURE
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [INFO] Invalid task '': you must specify a valid lifecycle phase, or a goal in the format plugin:goal or pluginGroupId:pluginArtifactId:pluginVersion:goal
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [INFO] For more information, run Maven with the -e switch
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] [INFO] Total time: < 1 second
          [artifact:mvn] [INFO] Finished at: Sat Nov 02 08:30:41 PDT 2013
          [artifact:mvn] [INFO] Final Memory: 33M/342M
          [artifact:mvn] [INFO] ------------------------------------------------------------------------
          [artifact:mvn] Java Result: 1
          
          Show
          Patrick Hunt added a comment - Giridharan Kesavan I applied the patch to 3.4 branch (minor conflict, see attachment) but it fails when running mvn-deploy as follows: (I did not try running with trunk) [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [ERROR] BUILD FAILURE [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [INFO] Invalid task '': you must specify a valid lifecycle phase, or a goal in the format plugin:goal or pluginGroupId:pluginArtifactId:pluginVersion:goal [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [INFO] For more information, run Maven with the -e switch [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [INFO] Total time: 50 seconds [artifact:mvn] [INFO] Finished at: Sat Nov 02 08:30:38 PDT 2013 [artifact:mvn] [INFO] Final Memory: 32M/351M [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] Java Result: 1 [artifact:mvn] [INFO] Scanning for projects... [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [ERROR] BUILD FAILURE [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [INFO] Invalid task '': you must specify a valid lifecycle phase, or a goal in the format plugin:goal or pluginGroupId:pluginArtifactId:pluginVersion:goal [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [INFO] For more information, run Maven with the -e switch [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [INFO] Total time: < 1 second [artifact:mvn] [INFO] Finished at: Sat Nov 02 08:30:39 PDT 2013 [artifact:mvn] [INFO] Final Memory: 32M/352M [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] Java Result: 1 [artifact:mvn] [INFO] Scanning for projects... [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [ERROR] BUILD FAILURE [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [INFO] Invalid task '': you must specify a valid lifecycle phase, or a goal in the format plugin:goal or pluginGroupId:pluginArtifactId:pluginVersion:goal [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [INFO] For more information, run Maven with the -e switch [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [INFO] Total time: < 1 second [artifact:mvn] [INFO] Finished at: Sat Nov 02 08:30:40 PDT 2013 [artifact:mvn] [INFO] Final Memory: 33M/352M [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] Java Result: 1 [artifact:mvn] [INFO] Scanning for projects... [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [ERROR] BUILD FAILURE [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [INFO] Invalid task '': you must specify a valid lifecycle phase, or a goal in the format plugin:goal or pluginGroupId:pluginArtifactId:pluginVersion:goal [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [INFO] For more information, run Maven with the -e switch [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] [INFO] Total time: < 1 second [artifact:mvn] [INFO] Finished at: Sat Nov 02 08:30:41 PDT 2013 [artifact:mvn] [INFO] Final Memory: 33M/342M [artifact:mvn] [INFO] ------------------------------------------------------------------------ [artifact:mvn] Java Result: 1
          Hide
          Patrick Hunt added a comment -

          also note that our "version" field in build.xml is not setup properly. it's currently "3.4.5" or "3.5.0" for branch34/trunk respectively. IMO We should update the version number in the build.xml to "3.4.6-SNAPSHOT" and "3.5.0-SNAPSHOT" respectively as part of this patch. During the release process we need to be sure to use "3.4.6"/"3.5.0" when building the release, then update branch34/trunk to "3.4.7-SNAPSHOT"/"3.6.0-SNAPSHOT" thereafter.

          Show
          Patrick Hunt added a comment - also note that our "version" field in build.xml is not setup properly. it's currently "3.4.5" or "3.5.0" for branch34/trunk respectively. IMO We should update the version number in the build.xml to "3.4.6-SNAPSHOT" and "3.5.0-SNAPSHOT" respectively as part of this patch. During the release process we need to be sure to use "3.4.6"/"3.5.0" when building the release, then update branch34/trunk to "3.4.7-SNAPSHOT"/"3.6.0-SNAPSHOT" thereafter.
          Patrick Hunt made changes -
          Attachment ZOOKEEPER-1430-br34-V3.patch [ 12611770 ]
          Hide
          Patrick Hunt added a comment -

          Giridharan Kesavan any insight on this? Am I doing it wrong?

          Show
          Patrick Hunt added a comment - Giridharan Kesavan any insight on this? Am I doing it wrong?
          Hide
          Patrick Hunt added a comment -
          Show
          Patrick Hunt added a comment - Also, Giri is this where you did the testing? https://repository.apache.org/content/groups/snapshots/org/apache/zookeeper/zookeeper/3.5.0-SNAPSHOT/ Notice that some jars are missing: here's a previous release https://repository.apache.org/content/groups/public/org/apache/zookeeper/zookeeper/3.4.5/
          Hide
          Giridharan Kesavan added a comment -

          I have uploaded a patch for both 3.4.6 and 3.5.0 with snapshot version numbers and also fixed a typo.

          this patch uploads 4 jars artifacts for the same pom.
          zookeeper main jar
          zookeeper test classifier jar
          zookeeper source classifier jar
          zookeeper javadoc classifier jar.
          This are the jar's that matters. Other's that I see in the link above are the asc's asc and md5 checksum's asc and those are not useful. Please let me know if I'm missing something.

          Show
          Giridharan Kesavan added a comment - I have uploaded a patch for both 3.4.6 and 3.5.0 with snapshot version numbers and also fixed a typo. this patch uploads 4 jars artifacts for the same pom. zookeeper main jar zookeeper test classifier jar zookeeper source classifier jar zookeeper javadoc classifier jar. This are the jar's that matters. Other's that I see in the link above are the asc's asc and md5 checksum's asc and those are not useful. Please let me know if I'm missing something.
          Giridharan Kesavan made changes -
          Attachment ZOOKEEPER-1430-3.5.0-v4.patch [ 12612305 ]
          Attachment ZOOKEEPER-1430-3.4.6-v4.patch [ 12612306 ]
          Hide
          Patrick Hunt added a comment -

          Thanks Giridharan Kesavan, this looks good to me. Deploy worked. I'll commit it.

          Show
          Patrick Hunt added a comment - Thanks Giridharan Kesavan , this looks good to me. Deploy worked. I'll commit it.
          Hide
          Patrick Hunt added a comment -

          Giridharan Kesavan in reviewing the patch further I noticed that you removed all the checksum generation, not just for the dist-maven files. Really we don't want to do this, we need it for example for the main artifacts. Did you do this for a reason? Can you add this back? Thanks!

          Show
          Patrick Hunt added a comment - Giridharan Kesavan in reviewing the patch further I noticed that you removed all the checksum generation, not just for the dist-maven files. Really we don't want to do this, we need it for example for the main artifacts. Did you do this for a reason? Can you add this back? Thanks!
          Hide
          Giridharan Kesavan added a comment -

          Patrick Hunt checksums both md5 and sha1 are generated by maven when it publishes to nexus repo.
          for ex:
          pls take a look at this url:
          https://repository.apache.org/content/groups/snapshots/org/apache/zookeeper/zookeeper/3.5.0-SNAPSHOT/

          Show
          Giridharan Kesavan added a comment - Patrick Hunt checksums both md5 and sha1 are generated by maven when it publishes to nexus repo. for ex: pls take a look at this url: https://repository.apache.org/content/groups/snapshots/org/apache/zookeeper/zookeeper/3.5.0-SNAPSHOT/
          Hide
          Patrick Hunt added a comment -

          Giridharan Kesavan these are checksums for the release artifacts, not maven. When we do a release artifact we include these checksums in that artifact. The maven publishing is separate (and I agree we don't need it there).

          Show
          Patrick Hunt added a comment - Giridharan Kesavan these are checksums for the release artifacts, not maven. When we do a release artifact we include these checksums in that artifact. The maven publishing is separate (and I agree we don't need it there).
          Hide
          Flavio Junqueira added a comment -

          Giridharan Kesavan, I was wondering if there is any progress here. Thanks!

          Show
          Flavio Junqueira added a comment - Giridharan Kesavan , I was wondering if there is any progress here. Thanks!
          Hide
          Giridharan Kesavan added a comment -

          v5 patch puts back the checksums in place

          Show
          Giridharan Kesavan added a comment - v5 patch puts back the checksums in place
          Giridharan Kesavan made changes -
          Attachment ZOOKEEPER-1430-3.4.6-v5.patch [ 12615759 ]
          Attachment ZOOKEEPER-1430-3.5.0-v5.patch [ 12615760 ]
          Hide
          Patrick Hunt added a comment - - edited

          Thanks Giridharan Kesavan. Unfortunately the "ant clean package" build is now failing though:

          BUILD FAILED
          /home/phunt/dev/svn/svn-zookeeper/build.xml:745: Could not find file /home/phunt/dev/svn/svn-zookeeper/build/zookeeper-3.5.0-SNAPSHOT/dist-maven/zookeeper-3.5.0-SNAPSHOT.pom to generate checksum for.
          

          Could you take a look? Thanks.

          Also a question - why do we end up with 4 copies of the pom file in the snapshot repo (repository.apache.org), rather than a single (as we do for each of the jars). afaict all the poms are the same, just we have four copies. Can we address that? Is it going to be an issue when staging/releasing? Is there some way you can address this, just have one pom rather than 4 copies?

          Show
          Patrick Hunt added a comment - - edited Thanks Giridharan Kesavan . Unfortunately the "ant clean package" build is now failing though: BUILD FAILED /home/phunt/dev/svn/svn-zookeeper/build.xml:745: Could not find file /home/phunt/dev/svn/svn-zookeeper/build/zookeeper-3.5.0-SNAPSHOT/dist-maven/zookeeper-3.5.0-SNAPSHOT.pom to generate checksum for. Could you take a look? Thanks. Also a question - why do we end up with 4 copies of the pom file in the snapshot repo (repository.apache.org), rather than a single (as we do for each of the jars). afaict all the poms are the same, just we have four copies. Can we address that? Is it going to be an issue when staging/releasing? Is there some way you can address this, just have one pom rather than 4 copies?
          Hide
          Flavio Junqueira added a comment -

          Giridharan Kesavan, Patrick Hunt, we really need to get this in so that we can release 3.4.6. I would really appreciate if we could work this one out soon.

          Show
          Flavio Junqueira added a comment - Giridharan Kesavan , Patrick Hunt , we really need to get this in so that we can release 3.4.6. I would really appreciate if we could work this one out soon.
          Hide
          Patrick Hunt added a comment -

          Flavio Junqueira I'd try to fix this, but I don't understand why the pom was renamed from $

          {final.name}

          to $

          {name}

          . But the naming seems inconsistent, it wasn't renamed everywhere and that's what's causing the most recent failure. I'd name it all back to finalname but Giri must have changed it for some reason (I don't know why).

          Giridharan Kesavan can you comment on why the pom was renamed? Can't we continue to call it by final.name as it was originally?

          Show
          Patrick Hunt added a comment - Flavio Junqueira I'd try to fix this, but I don't understand why the pom was renamed from $ {final.name} to $ {name} . But the naming seems inconsistent, it wasn't renamed everywhere and that's what's causing the most recent failure. I'd name it all back to finalname but Giri must have changed it for some reason (I don't know why). Giridharan Kesavan can you comment on why the pom was renamed? Can't we continue to call it by final.name as it was originally?
          Hide
          Giridharan Kesavan added a comment -

          Patrick Hunt $

          {final.name}

          is nothing but $

          {name}

          -$

          {version}

          and by convention maven projects doesn't have pom file that are versioned. When publishing the pom.xml file maven by itself will figureout the version of the pom file and publish it.

          To answer your second question about multiple pom's. it's not b'coz of the pom name, it's bcoz the way the ant macro def call's the individual publish task. it consider's every deploy call as separate module and publishes the same pom file with different build number.

          With this v6 patch I have made it a single call and all the artifacts will be published at one go.

          I have tested the patch for clean package, mvn-deploy, and mvn-deploy the staging as well.

          Show
          Giridharan Kesavan added a comment - Patrick Hunt $ {final.name} is nothing but $ {name} -$ {version} and by convention maven projects doesn't have pom file that are versioned. When publishing the pom.xml file maven by itself will figureout the version of the pom file and publish it. To answer your second question about multiple pom's. it's not b'coz of the pom name, it's bcoz the way the ant macro def call's the individual publish task. it consider's every deploy call as separate module and publishes the same pom file with different build number. With this v6 patch I have made it a single call and all the artifacts will be published at one go. I have tested the patch for clean package, mvn-deploy, and mvn-deploy the staging as well.
          Giridharan Kesavan made changes -
          Attachment ZOOKEEPER-1430-3.4.6-v6.patch [ 12619216 ]
          Attachment ZOOKEEPER-1430-3.5.0-v6.patch [ 12619217 ]
          Hide
          Patrick Hunt added a comment -

          Committed to 3.4.6 and trunk. Thanks Giri!

          Show
          Patrick Hunt added a comment - Committed to 3.4.6 and trunk. Thanks Giri!
          Patrick Hunt made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in ZooKeeper-trunk #2160 (See https://builds.apache.org/job/ZooKeeper-trunk/2160/)
          ZOOKEEPER-1430. add maven deploy support to the build (Giridharan Kesavan via phunt) (phunt: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1552469)

          • /zookeeper/trunk/CHANGES.txt
          • /zookeeper/trunk/build.xml
          • /zookeeper/trunk/ivy.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in ZooKeeper-trunk #2160 (See https://builds.apache.org/job/ZooKeeper-trunk/2160/ ) ZOOKEEPER-1430 . add maven deploy support to the build (Giridharan Kesavan via phunt) (phunt: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1552469 ) /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/build.xml /zookeeper/trunk/ivy.xml
          Hide
          Flavio Junqueira added a comment -
          Show
          Flavio Junqueira added a comment - Thanks, Patrick Hunt , Giridharan Kesavan .
          Hide
          Flavio Junqueira added a comment -

          Closing issues after releasing 3.4.6.

          Show
          Flavio Junqueira added a comment - Closing issues after releasing 3.4.6.
          Flavio Junqueira made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Giridharan Kesavan
              Reporter:
              Patrick Hunt
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development