Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-1391

zkCli dies on NoAuth

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Major
        • Resolution: Duplicate
        • Affects Version/s: 3.4.2
        • Fix Version/s: 3.5.0
        • Component/s: java client
        • Labels:
          None

          Description

          [zk: localhost:2181(CONNECTED) 1] create /sasltest/n4 c sasl:notme@EXAMPLE.COM:cdrwa
          Created /sasltest/n4
          [zk: localhost:2181(CONNECTED) 2] ls /sasltest/n4
          Exception in thread "main" org.apache.zookeeper.KeeperException$NoAuthException: KeeperErrorCode = NoAuth for /sasltest/n4
          at org.apache.zookeeper.KeeperException.create(KeeperException.java:113)
          at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
          at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:1448)
          at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:1476)
          at org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:717)
          at org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:593)
          at org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:365)
          at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323)
          at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282)

          1. Text File
            ZOOKEEPER-1391.patch
            4 kB
            Hartmut Lang
          2. Text File
            ZOOKEEPER-1391.patch
            3 kB
            Hartmut Lang

            Issue Links

            relates to

            Bug - A problem which impairs or prevents the functions of the product. ZOOKEEPER-1307 zkCli.sh is exiting when an Invalid ACL exception is thrown from setACL command through client

            • Minor - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              hlang Hartmut Lang added a comment -

              Same thing can happen for create if ACL is invalid.

              [zk: localhost:2181(CONNECTED) 1] create /sasltest/n4 c sasl:notme@EXAMPLE.COM:cdrwa
Exception in thread "main" org.apache.zookeeper.KeeperException$InvalidACLException: KeeperErrorCode = InvalidACL for /sasltest/n4
	at org.apache.zookeeper.KeeperException.create(KeeperException.java:121)
        ....
              Show
              hlang Hartmut Lang added a comment - Same thing can happen for create if ACL is invalid. [zk: localhost:2181(CONNECTED) 1] create /sasltest/n4 c sasl:notme@EXAMPLE.COM:cdrwa Exception in thread "main" org.apache.zookeeper.KeeperException$InvalidACLException: KeeperErrorCode = InvalidACL for /sasltest/n4 at org.apache.zookeeper.KeeperException.create(KeeperException.java:121) ....
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12518829/ZOOKEEPER-1391.patch
              against trunk revision 1302073.

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
              Please justify why no new tests are needed for this patch.
              Also please list what manual steps were performed to verify this patch.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 core tests. The patch failed core unit tests.

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/996//testReport/
              Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/996//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
              Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/996//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518829/ZOOKEEPER-1391.patch against trunk revision 1302073. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/996//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/996//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/996//console This message is automatically generated.
              Hide
              Permalink
              phunt Patrick Hunt added a comment -

              the test failure is some unrelated flakey test, I've triggered another patch test on jenkins.

              However, this patch should include a test that verifies the fix (also that it doesn't crop up again). Also, would it be possible for you to fix this in 3.4 as well? (sep patch, same jira, but against branch-3.4)

              Show
              phunt Patrick Hunt added a comment - the test failure is some unrelated flakey test, I've triggered another patch test on jenkins. However, this patch should include a test that verifies the fix (also that it doesn't crop up again). Also, would it be possible for you to fix this in 3.4 as well? (sep patch, same jira, but against branch-3.4)
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12518829/ZOOKEEPER-1391.patch
              against trunk revision 1302213.

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
              Please justify why no new tests are needed for this patch.
              Also please list what manual steps were performed to verify this patch.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              +1 core tests. The patch passed core unit tests.

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/999//testReport/
              Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/999//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
              Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/999//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518829/ZOOKEEPER-1391.patch against trunk revision 1302213. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/999//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/999//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/999//console This message is automatically generated.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              +1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12519719/ZOOKEEPER-1391.patch
              against trunk revision 1302736.

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 3 new or modified tests.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              +1 core tests. The patch passed core unit tests.

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1005//testReport/
              Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1005//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
              Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1005//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519719/ZOOKEEPER-1391.patch against trunk revision 1302736. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1005//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1005//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1005//console This message is automatically generated.
              Hide
              Permalink
              hlang Hartmut Lang added a comment -

              For branch-3.4 this was already fixed with ZOOKEEPER-1307

              Show
              hlang Hartmut Lang added a comment - For branch-3.4 this was already fixed with ZOOKEEPER-1307
              Hide
              Permalink
              fournc Camille Fournier added a comment -

              This test will pass even without the fixes you have made. Are you sure that 1307 doesn't fix this as well?

              Show
              fournc Camille Fournier added a comment - This test will pass even without the fixes you have made. Are you sure that 1307 doesn't fix this as well?
              Hide
              Permalink
              hlang Hartmut Lang added a comment -

              Yes, ZOOKEEPER-1307 does already fix this in a more generic way.
              When i committed the patch, 1307 was not part of trunk.
              But now the patch for this issue (ZOOKEEPER-1391) seems to be obsolete.

              Show
              hlang Hartmut Lang added a comment - Yes, ZOOKEEPER-1307 does already fix this in a more generic way. When i committed the patch, 1307 was not part of trunk. But now the patch for this issue ( ZOOKEEPER-1391 ) seems to be obsolete.
              Hide
              Permalink
              michim Michi Mutsuzaki added a comment -

              Verified that this was fixed in ZOOKEEPER-1307.

              --Michi

              Show
              michim Michi Mutsuzaki added a comment - Verified that this was fixed in ZOOKEEPER-1307 . --Michi

                People

                • Assignee:
                  hlang Hartmut Lang
                  Reporter:
                  thw Thomas Weise
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development