Added, plus test and include in public javadoc.

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12512211/ZOOKEEPER-1377.patch
against trunk revision 1234974.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/924//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/924//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/924//console

This message is automatically generated.

fixed the (bogus) findbugs warning

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12512218/ZOOKEEPER-1377.patch
against trunk revision 1234974.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/925//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/925//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/925//console

This message is automatically generated.

+1 looks nice. Should we consider adding this to 3.4? I realize it's a "new feature" but it is also an awfully useful utility.

Sounds reasonable to me given it's a standalone (debug) utility. Feel free. Thx

Integrated in ZooKeeper-trunk #1499 (See https://builds.apache.org/job/ZooKeeper-trunk/1499/)
ZOOKEEPER-1377. add support for dumping a snapshot file content (similar to LogFormatter) (phunt via camille) (Revision 1302213)

Result = SUCCESS
camille : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302213
Files :

• /zookeeper/trunk/CHANGES.txt
• /zookeeper/trunk/build.xml
• /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/SnapshotFormatter.java
• /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/InvalidSnapshotTest.java