ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1376

zkServer.sh does not correctly check for $SERVER_JVMFLAGS

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.3, 3.3.4
    • Fix Version/s: 3.3.7, 3.4.5
    • Component/s: scripts
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      It will always include it even if not defined, although not much harm.

      if [ "x$SERVER_JVMFLAGS" ]
      then
      JVMFLAGS="$SERVER_JVMFLAGS $JVMFLAGS"
      fi

      should use the std idiom.

      1. ZOOKEEPER-1376.patch
        0.3 kB
        Skye Wanderman-Milne

        Issue Links

          Activity

          Patrick Hunt created issue -
          Eugene Koontz made changes -
          Field Original Value New Value
          Link This issue depends upon ZOOKEEPER-1012 [ ZOOKEEPER-1012 ]
          Hide
          Skye Wanderman-Milne added a comment -

          This is already fixed in trunk but as part of a new feature (see ZOOKEEPER-1161).

          Here's a patch that can be applied directly to 3.3.3 and 3.3.4.

          Show
          Skye Wanderman-Milne added a comment - This is already fixed in trunk but as part of a new feature (see ZOOKEEPER-1161 ). Here's a patch that can be applied directly to 3.3.3 and 3.3.4.
          Skye Wanderman-Milne made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Affects Version/s 3.3.4 [ 12316276 ]
          Skye Wanderman-Milne made changes -
          Attachment ZOOKEEPER-1376.patch [ 12546108 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12546108/ZOOKEEPER-1376.patch
          against trunk revision 1386496.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1185//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546108/ZOOKEEPER-1376.patch against trunk revision 1386496. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1185//console This message is automatically generated.
          Hide
          Henry Robinson added a comment -

          +1, patch looks good to me. I'll commit shortly to 3.3 and 3.4.

          Show
          Henry Robinson added a comment - +1, patch looks good to me. I'll commit shortly to 3.3 and 3.4.
          Henry Robinson made changes -
          Fix Version/s 3.3.7 [ 12321882 ]
          Fix Version/s 3.4.5 [ 12321883 ]
          Hide
          Henry Robinson added a comment -

          I just committed this to 3.3 and 3.4. Thanks Skye!

          Show
          Henry Robinson added a comment - I just committed this to 3.3 and 3.4. Thanks Skye!
          Henry Robinson made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Henry Robinson made changes -
          Assignee Skye Wanderman-Milne [ skye ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          238d 21h 2m 1 Skye Wanderman-Milne 21/Sep/12 23:41
          Patch Available Patch Available Resolved Resolved
          24m 31s 1 Henry Robinson 22/Sep/12 00:05

            People

            • Assignee:
              Skye Wanderman-Milne
              Reporter:
              Patrick Hunt
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development