Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-1352

server.InvalidSnapshotTest is using connection timeouts that are too short

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.3.4
    • 3.4.3, 3.3.5, 3.5.0
    • tests
    • None
    • Reviewed

    Description

      InvalidSnapshotTest is using connection timeouts that are too short, see this false failure:
      https://builds.apache.org/job/ZooKeeper_branch33_solaris/65/testReport/junit/org.apache.zookeeper.server/InvalidSnapshotTest/testInvalidSnapshot/

      org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /invalidsnap-0
      	at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
      	at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
      	at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:643)
      	at org.apache.zookeeper.server.InvalidSnapshotTest.testInvalidSnapshot(InvalidSnapshotTest.java:71)
      

      Also in looking at the test itself it could use some cleanup (reuse features from ClientBase test utils)

      Attachments

        1. ZOOKEEPER-1352_br33.patch
          6 kB
          Patrick D. Hunt
        2. ZOOKEEPER-1352_br34.patch
          7 kB
          Patrick D. Hunt
        3. ZOOKEEPER-1352_trunk.patch
          7 kB
          Mahadev Konar
        4. ZOOKEEPER-1352_trunk.patch
          7 kB
          Patrick D. Hunt

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            phunt Patrick D. Hunt Assign to me
            phunt Patrick D. Hunt
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment