[ZOOKEEPER-1352] server.InvalidSnapshotTest is using connection timeouts that are too short

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.4
• Fix Version/s: 3.4.3, 3.3.5, 3.5.0
• Component/s: tests
• Hadoop Flags: Reviewed
• Assignee: Patrick D. Hunt
• Reporter: Patrick D. Hunt
• Created: 05/Jan/12 19:12
• Updated: 06/Feb/12 10:58
• Resolved: 06/Feb/12 08:52

Description

InvalidSnapshotTest is using connection timeouts that are too short, see this false failure:
https://builds.apache.org/job/ZooKeeper_branch33_solaris/65/testReport/junit/org.apache.zookeeper.server/InvalidSnapshotTest/testInvalidSnapshot/

org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /invalidsnap-0
	at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
	at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
	at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:643)
	at org.apache.zookeeper.server.InvalidSnapshotTest.testInvalidSnapshot(InvalidSnapshotTest.java:71)

Also in looking at the test itself it could use some cleanup (reuse features from ClientBase test utils)