Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-1352

server.InvalidSnapshotTest is using connection timeouts that are too short

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.4
    • Fix Version/s: 3.4.3, 3.3.5, 3.5.0
    • Component/s: tests
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      InvalidSnapshotTest is using connection timeouts that are too short, see this false failure:
      https://builds.apache.org/job/ZooKeeper_branch33_solaris/65/testReport/junit/org.apache.zookeeper.server/InvalidSnapshotTest/testInvalidSnapshot/

      org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /invalidsnap-0
      	at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
      	at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
      	at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:643)
      	at org.apache.zookeeper.server.InvalidSnapshotTest.testInvalidSnapshot(InvalidSnapshotTest.java:71)
      

      Also in looking at the test itself it could use some cleanup (reuse features from ClientBase test utils)

        Attachments

        1. ZOOKEEPER-1352_br33.patch
          6 kB
          Patrick Hunt
        2. ZOOKEEPER-1352_br34.patch
          7 kB
          Patrick Hunt
        3. ZOOKEEPER-1352_trunk.patch
          7 kB
          Patrick Hunt
        4. ZOOKEEPER-1352_trunk.patch
          7 kB
          Mahadev konar

          Activity

            People

            • Assignee:
              phunt Patrick Hunt
              Reporter:
              phunt Patrick Hunt
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: