ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1345

Add a .gitignore file with general exclusions and Eclipse project files excluded

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.5.0
    • Fix Version/s: 3.4.3, 3.3.5, 3.5.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I tried looking for an .gitignore file in the ZK sources but I could not find one.

      Preferably, we could add one with the following:

      #	.classpath
      #	.eclipse/
      #	.project
      #	.revision/
      #	.settings/
      #	build/
      #	src/c/generated/
      #	src/java/generated/
      #	src/java/lib/ant-eclipse-1.0-jvm1.2.jar
      #	src/java/lib/ivy-2.2.0.jar
      

      To avoid losing much when doing "git clean -fd" and the likes while cleaning up the working repo dirs during development. This will aid those who use git mirrors for contributions a lot.

        Activity

        Harsh J created issue -
        Harsh J made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-1345.patch [ 12508855 ]
        Harsh J made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Harsh J made changes -
        Assignee Harsh J [ qwertymaniac ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12508855/ZOOKEEPER-1345.patch
        against trunk revision 1225352.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/868//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/868//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/868//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12508855/ZOOKEEPER-1345.patch against trunk revision 1225352. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/868//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/868//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/868//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        Committed. Good idea, thanks Harsh!

        Show
        Patrick Hunt added a comment - Committed. Good idea, thanks Harsh!
        Patrick Hunt made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 3.5.0 [ 12316644 ]
        Fix Version/s 3.3.5 [ 12319081 ]
        Fix Version/s 3.4.3 [ 12319288 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1413 (See https://builds.apache.org/job/ZooKeeper-trunk/1413/)
        ZOOKEEPER-1345. Add a .gitignore file with general exclusions and Eclipse project files excluded (Harsh J via phunt)

        phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225927
        Files :

        • /zookeeper/trunk/.gitignore
        • /zookeeper/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1413 (See https://builds.apache.org/job/ZooKeeper-trunk/1413/ ) ZOOKEEPER-1345 . Add a .gitignore file with general exclusions and Eclipse project files excluded (Harsh J via phunt) phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225927 Files : /zookeeper/trunk/.gitignore /zookeeper/trunk/CHANGES.txt

          People

          • Assignee:
            Harsh J
            Reporter:
            Harsh J
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development