Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-1342

quorum Listener & LearnerCnxAcceptor are missing thread names

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.5.0
    • quorum
    • Reviewed

    Attachments

      1. ZOOKEEPER-1342.patch
        2 kB
        Patrick D. Hunt
      2. ZOOKEEPER-1342.patch
        1 kB
        Rakesh Radhakrishnan

      Activity

        Attached trivial patch to give useful name.

        rakeshr Rakesh Radhakrishnan added a comment - Attached trivial patch to give useful name.

        Reason for no test case: just naming the thread.

        rakeshr Rakesh Radhakrishnan added a comment - Reason for no test case: just naming the thread.
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12508500/ZOOKEEPER-1342.patch
        against trunk revision 1221868.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/854//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/854//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/854//console

        This message is automatically generated.

        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12508500/ZOOKEEPER-1342.patch against trunk revision 1221868. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/854//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/854//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/854//console This message is automatically generated.

        minor change, make ss private final for protection.

        phunt Patrick D. Hunt added a comment - minor change, make ss private final for protection.

        Thanks Rakesh!

        phunt Patrick D. Hunt added a comment - Thanks Rakesh!
        hudson Hudson added a comment -

        Integrated in ZooKeeper-trunk #1410 (See https://builds.apache.org/job/ZooKeeper-trunk/1410/)
        ZOOKEEPER-1342. quorum Listener & LearnerCnxAcceptor are missing thread names (Rakesh R via phunt)

        phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225059
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
        hudson Hudson added a comment - Integrated in ZooKeeper-trunk #1410 (See https://builds.apache.org/job/ZooKeeper-trunk/1410/ ) ZOOKEEPER-1342 . quorum Listener & LearnerCnxAcceptor are missing thread names (Rakesh R via phunt) phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225059 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java

        People

          rakeshr Rakesh Radhakrishnan
          rakeshr Rakesh Radhakrishnan
          Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved: