ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1338

class cast exceptions may be thrown by multi ErrorResult class (invalid equals)

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.0
    • Fix Version/s: 3.4.3, 3.5.0
    • Component/s: java client
    • Labels:
      None

      Description

      There's a bug in ErrorResult and perhaps some of the other OpResult equals methods in multi.

      1. ZOOKEEPER-1338.patch
        5 kB
        Mahadev konar
      2. ZOOKEEPER-1338.patch
        6 kB
        Mahadev konar
      3. ZOOKEEPER-1338.patch
        6 kB
        Patrick Hunt

        Activity

        Hide
        Patrick Hunt added a comment -

        Fixes the bugs in equals, also makes OpResult abstract.

        Show
        Patrick Hunt added a comment - Fixes the bugs in equals, also makes OpResult abstract.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12508332/ZOOKEEPER-1338.patch
        against trunk revision 1221868.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/848//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/848//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/848//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12508332/ZOOKEEPER-1338.patch against trunk revision 1221868. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/848//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/848//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/848//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12508332/ZOOKEEPER-1338.patch
        against trunk revision 1240905.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/945//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12508332/ZOOKEEPER-1338.patch against trunk revision 1240905. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/945//console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        Cancelling patch. Looks like its gone stale.

        Show
        Mahadev konar added a comment - Cancelling patch. Looks like its gone stale.
        Hide
        Mahadev konar added a comment -

        Updated patch that applies to trunk and 3.4 branch.

        Show
        Mahadev konar added a comment - Updated patch that applies to trunk and 3.4 branch.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12513417/ZOOKEEPER-1338.patch
        against trunk revision 1240949.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/950//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/950//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/950//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12513417/ZOOKEEPER-1338.patch against trunk revision 1240949. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/950//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/950//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/950//console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        Updated patch after ZOOKEEPER-1337 was committed.

        Show
        Mahadev konar added a comment - Updated patch after ZOOKEEPER-1337 was committed.
        Hide
        Mahadev konar added a comment -

        I just committed this to 3.4 and trunk. Thanks Pat!

        Show
        Mahadev konar added a comment - I just committed this to 3.4 and trunk. Thanks Pat!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1451 (See https://builds.apache.org/job/ZooKeeper-trunk/1451/)
        ZOOKEEPER-1338. class cast exceptions may be thrown by multi ErrorResult class (invalid equals) (phunt via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240959
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/OpResult.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1451 (See https://builds.apache.org/job/ZooKeeper-trunk/1451/ ) ZOOKEEPER-1338 . class cast exceptions may be thrown by multi ErrorResult class (invalid equals) (phunt via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240959 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/main/org/apache/zookeeper/OpResult.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development