[ZOOKEEPER-1334] Zookeeper 3.4.x is not OSGi compliant - MANIFEST.MF is flawed

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.6, 3.5.0
• Hadoop Flags: Reviewed
• Assignee: Claus Ibsen
• Reporter: Claus Ibsen
• Created: 20/Dec/11 16:31
• Updated: 08/Oct/14 15:55
• Resolved: 19/Dec/12 08:05

Description

In Zookeeper 3.3.x you use log4j for logging, and the maven dep is

eg from 3.3.4

    <dependency>
      <groupId>log4j</groupId>
      <artifactId>log4j</artifactId>
      <version>1.2.15</version>
      <scope>compile</scope>
    </dependency>

Now in 3.4.0 or better you changed to use slf4j also/instead. The maven pom.xml now includes:

  <dependency>
      <groupId>org.slf4j</groupId>
      <artifactId>slf4j-api</artifactId>
      <version>1.6.1</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>org.slf4j</groupId>
      <artifactId>slf4j-log4j12</artifactId>
      <version>1.6.1</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>log4j</groupId>
      <artifactId>log4j</artifactId>
      <version>1.2.15</version>
      <scope>compile</scope>
    </dependency>

But the META-INF/MANIFEST.MF file in the distribution did not change to reflect this.

The 3.3.4 MANIFEST.MF, import packages

Import-Package: javax.management,org.apache.log4j,org.osgi.framework;v
 ersion="[1.4,2.0)",org.osgi.util.tracker;version="[1.1,2.0)"

And the 3.4.1 MANIFEST.MF, import packages:

Import-Package: javax.management,org.apache.log4j,org.osgi.framework;v
 ersion="[1.4,2.0)",org.osgi.util.tracker;version="[1.1,2.0)"

This makes using zookeeper 3.4.x in OSGi environments not possible, as we get NoClassDefFoundException for slf4j classes.

Issue Links

• is depended upon by: CAMEL-4803 Upgrade to zookeeper 3.4.x
• is related to: ZOOKEEPER-1647 OSGi package import/export changes not applied to bin-jar
• is related to: ZOOKEEPER-1078 add maven build support to ZooKeeper
• relates to: ZOOKEEPER-2056 Zookeeper 3.4.x and 3.5.0-alpha is not OSGi compliant