ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1325

Log maxClientCnxn warning in INFO level

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Invalid
    • Affects Version/s: 3.3.3, 3.3.4, 3.4.0
    • Fix Version/s: None
    • Component/s: server
    • Labels:

      Description

      When Hbase client ZooKeeperWatcher gets ConnectionLossException (/hbase/rs or /hbase), it is very hard debug the ZK server log if ZK server has started using log4j INFO level.
      When maxClientCnxn limit is reached for a single client (at the socket level), it will be nice to log it in INFO level instead of WARN. It will help hbase clients (Region server, HMaster, and HBase cient lib) to debug the issue in production.

      
      3.4 - src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 
      3.3.4 - src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
      
       public void run() {
              while (!ss.socket().isClosed()) {
                  try {
                              ...
                              ...
                      
                              if (maxClientCnxns > 0 && cnxncount >= maxClientCnxns){
                                  LOG.info("Too many connections from " + ia
                                           + " - max is " + maxClientCnxns );
                                  sc.close();
                              } 
                              ... 
          }
      
      

        Activity

        Hide
        Patrick Hunt added a comment -

        No worries. Feel free to enter jiras if you notice a problem.

        Show
        Patrick Hunt added a comment - No worries. Feel free to enter jiras if you notice a problem.
        Hide
        Mubarak Seyed added a comment -

        I could see it. Sorry it was my mistake.

        2011-11-30 14:13:57,252 - WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn$Factory@247] - Too many connections from /xx.xx.xxx.xxx - max is 3

        Show
        Mubarak Seyed added a comment - I could see it. Sorry it was my mistake. 2011-11-30 14:13:57,252 - WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn$Factory@247] - Too many connections from /xx.xx.xxx.xxx - max is 3
        Hide
        Mubarak Seyed added a comment -

        sorry that it was my mistake to look at wrong logs, closing it.
        Thanks.

        Show
        Mubarak Seyed added a comment - sorry that it was my mistake to look at wrong logs, closing it. Thanks.

          People

          • Assignee:
            Unassigned
            Reporter:
            Mubarak Seyed
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development