Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.0
    • Fix Version/s: 3.4.2, 3.5.0
    • Component/s: c client
    • Labels:
      None
    • Environment:

      freebsd 6.4

    • Hadoop Flags:
      Reviewed

      Description

      EAI_NODATA and EAI_ADDRFAMILY have been deprecated in FreeBSD. I'm getting this error:

      src/zookeeper.c: In function `getaddrinfo_errno':
      src/zookeeper.c:446: error: `EAI_NODATA' undeclared (first use in this function)
      src/zookeeper.c:446: error: (Each undeclared identifier is reported only once
      src/zookeeper.c:446: error: for each function it appears in.)
      src/zookeeper.c: In function `getaddrs':
      src/zookeeper.c:581: error: `EAI_ADDRFAMILY' undeclared (first use in this function)

      I'll submit a patch.

      --Michi

      1. ZOOKEEPER-1323.patch
        1.0 kB
        Michi Mutsuzaki

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12506693/ZOOKEEPER-1323.patch
        against trunk revision 1212192.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/826//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/826//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/826//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506693/ZOOKEEPER-1323.patch against trunk revision 1212192. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/826//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/826//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/826//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        Thanks Michi!

        Show
        Patrick Hunt added a comment - Thanks Michi!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1397 (See https://builds.apache.org/job/ZooKeeper-trunk/1397/)
        ZOOKEEPER-1323. c client doesn't compile on freebsd (michi mutsuzaki via phunt)

        phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214537
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/c/src/zookeeper.c
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1397 (See https://builds.apache.org/job/ZooKeeper-trunk/1397/ ) ZOOKEEPER-1323 . c client doesn't compile on freebsd (michi mutsuzaki via phunt) phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214537 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/c/src/zookeeper.c

          People

          • Assignee:
            Michi Mutsuzaki
            Reporter:
            Michi Mutsuzaki
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development