Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.4.0
    • Fix Version/s: 3.4.1, 3.5.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In http://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.0/ the test jar cannot be accessed by maven.

      There are two possible solutions to this.
      a) rename zookeeper-3.4.0-test.jar to zookeeper-3.4.0-tests.jar and remove zookeeper-3.4.0-test.pom*
      With this, the maven can access the test jar with

           <dependency>
             <groupId>org.apache.zookeeper</groupId>
             <artifactId>zookeeper</artifactId>
             <version>3.4.0</version>
             <type>test-jar</type>
             <scope>test</scope>
           </dependency>
      

      b) Alternatively, zookeeper test could be it's own submodule. To do this, it must be deployed in the following layout

      ./org/apache/zookeeper/zookeeper-test/3.4.0-BK-SNAPSHOT/zookeeper-test-3.4.0.jar
      ./org/apache/zookeeper/zookeeper-test/3.4.0-BK-SNAPSHOT/zookeeper-test-3.4.0.jar.md5
      ./org/apache/zookeeper/zookeeper-test/3.4.0-BK-SNAPSHOT/zookeeper-test-3.4.0.jar.sha1
      ./org/apache/zookeeper/zookeeper-test/3.4.0-BK-SNAPSHOT/zookeeper-test-3.4.0.pom
      ./org/apache/zookeeper/zookeeper-test/3.4.0-BK-SNAPSHOT/zookeeper-test-3.4.0.pom.md5
      ./org/apache/zookeeper/zookeeper-test/3.4.0-BK-SNAPSHOT/zookeeper-test-3.4.0.pom.sha1
      

      This can then be accessed by maven with

           <dependency>
             <groupId>org.apache.zookeeper</groupId>
             <artifactId>zookeeper-test</artifactId>
             <version>3.4.0</version>
             <scope>test</scope>
           </dependency>
      

      I think a) is the better solution.

        Activity

        Hide
        Patrick Hunt added a comment -

        As part of fixing this it would be great to have something we could use to validate ZK deployment to the maven repo as part of the release process. Mahadev and I tested this ourselves, but didn't notice the test issue.

        Show
        Patrick Hunt added a comment - As part of fixing this it would be great to have something we could use to validate ZK deployment to the maven repo as part of the release process. Mahadev and I tested this ourselves, but didn't notice the test issue.
        Hide
        Ivan Kelly added a comment -

        It could be tested with a pom.xml that pulls in the different parts. I don't know how to automate that testing though.

        Show
        Ivan Kelly added a comment - It could be tested with a pom.xml that pulls in the different parts. I don't know how to automate that testing though.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12505642/ZOOKEEPER-1311.diff
        against trunk revision 1202557.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/800//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/800//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/800//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12505642/ZOOKEEPER-1311.diff against trunk revision 1202557. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/800//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/800//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/800//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        committed, thanks Ivan!

        Show
        Patrick Hunt added a comment - committed, thanks Ivan!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1381 (See https://builds.apache.org/job/ZooKeeper-trunk/1381/)
        ZOOKEEPER-1311. ZooKeeper test jar is broken (Ivan Kelly via phunt)

        phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208979
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/build.xml
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1381 (See https://builds.apache.org/job/ZooKeeper-trunk/1381/ ) ZOOKEEPER-1311 . ZooKeeper test jar is broken (Ivan Kelly via phunt) phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1208979 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/build.xml

          People

          • Assignee:
            Ivan Kelly
            Reporter:
            Ivan Kelly
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development