[ZOOKEEPER-1305] zookeeper.c:prepend_string func can dereference null ptr

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.3
• Fix Version/s: 3.4.1, 3.3.6, 3.5.0
• Component/s: c client
• Labels: patch

Environment

All

• Release Note: return ZBADARGUMENTS when passed NULL zhandle instead of dereferencing null pointer.
• Assignee: Daniel Lescohier
• Reporter: Daniel Lescohier
• Created: 18/Nov/11 18:23
• Updated: 03/May/12 02:06
• Resolved: 08/Dec/11 22:03

Description

All the callers of the function prepend_string make a call to prepend_string before checking that zhandle_t *zh is not null. At the top of prepend_string, zh is dereferenced without checking for a null ptr:

static char* prepend_string(zhandle_t zh, const char client_path) {
char *ret_str;
if (zh->chroot == NULL)
return (char *) client_path;

I propose fixing this by adding the check here in prepend_string:

static char* prepend_string(zhandle_t zh, const char client_path) {
char *ret_str;
if (zh==NULL || zh->chroot == NULL)
return (char *) client_path;

Issue Links

• is duplicated by: ZOOKEEPER-1461 Zookeeper C client doesn't check for NULL before dereferencing in prepend_string