ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1268

problems with read only mode, intermittent test failures and ERRORs in the log

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.4.0, 3.5.0
    • Fix Version/s: 3.4.0, 3.5.0
    • Component/s: server
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I'm having a lot problems testing the 3.4.0 release candidate (0). I'm seeing frequent failures in RO unit tests, also the solaris tests are broken on jenkins, some of which is due to RO mode:
      https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_trunk_solaris/30/#showFailuresLink

      I'm also seeing ERROR level messages in the logs during test runs that are a result of attempting to start RO mode.

      Given this is a new feature, one that could be very disruptive, I think we need to control whether the feature is enabled or not through a config option (system prop is fine), disabled by default.

      I'll look at the RO mode tests to see if I can find the cause of the failures on solaris, but I may also turn off these tests for the time being. (I need to look at this further).

      I'm marking this as a blocker for 3.4.0, Mahadev LMK if you feel similarly or whether I should be shooting for 3.4.1 with this. (or perhaps I'm just way off in general).

      1. ZOOKEEPER-1268_branch34.patch
        8 kB
        Patrick Hunt
      2. ZOOKEEPER-1268.patch
        8 kB
        Patrick Hunt

        Activity

        Hide
        Patrick Hunt added a comment -

        This patch (one for trunk, one for 34) introduces ROM as an experimental feature, most critically it's "off by default". afaict ROM was never documented beyond JIRA/wiki, so it's safe to say experimental imo. I added details to the admin guide to capture information on how to turn on or find out more.

        I also made a small tweak to the test to allow it to run on slow hardware.

        Show
        Patrick Hunt added a comment - This patch (one for trunk, one for 34) introduces ROM as an experimental feature, most critically it's "off by default". afaict ROM was never documented beyond JIRA/wiki, so it's safe to say experimental imo. I added details to the admin guide to capture information on how to turn on or find out more. I also made a small tweak to the test to allow it to run on slow hardware.
        Hide
        Camille Fournier added a comment -

        +1, looks good to me.

        Show
        Camille Fournier added a comment - +1, looks good to me.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12501372/ZOOKEEPER-1268.patch
        against trunk revision 1190450.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/727//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/727//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/727//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501372/ZOOKEEPER-1268.patch against trunk revision 1190450. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/727//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/727//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/727//console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        looks good to me. committing now.

        Show
        Mahadev konar added a comment - looks good to me. committing now.
        Hide
        Mahadev konar added a comment -

        Just committed this to 3.4 and trunk. Thanks Pat!

        Show
        Mahadev konar added a comment - Just committed this to 3.4 and trunk. Thanks Pat!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1351 (See https://builds.apache.org/job/ZooKeeper-trunk/1351/)
        ZOOKEEPER-1268. problems with read only mode, intermittent test failures and ERRORs in the log (phunt via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195854
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1351 (See https://builds.apache.org/job/ZooKeeper-trunk/1351/ ) ZOOKEEPER-1268 . problems with read only mode, intermittent test failures and ERRORs in the log (phunt via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195854 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development