ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1256

ClientPortBindTest is failing on Mac OS X

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.4, 3.5.0
    • Component/s: tests
    • Labels:
      None
    • Environment:

      Mac OS X

    • Hadoop Flags:
      Reviewed

      Description

      ClientPortBindTest is failing consistently on Mac OS X.

      1. ClientPortBindTest.log
        9 kB
        Daniel Gómez Ferro
      2. ZOOKEEPER-1256.patch
        0.7 kB
        Daniel Gómez Ferro
      3. ZOOKEEPER-1256.patch
        2 kB
        Daniel Gómez Ferro

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12501055/ZOOKEEPER-1256.patch
          against trunk revision 1189318.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/693//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501055/ZOOKEEPER-1256.patch against trunk revision 1189318. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/693//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12501057/ZOOKEEPER-1256.patch
          against trunk revision 1189318.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/694//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/694//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/694//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501057/ZOOKEEPER-1256.patch against trunk revision 1189318. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/694//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/694//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/694//console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          I don't think we can just remove this, see "Textual representation of IPv6 scoped addresses" here:
          http://download.oracle.com/javase/1,5.0/docs/api/java/net/Inet6Address.html

          What is the failure you are seeing? Do you have ipv6 address or ipv4 on your loopback interface? If ipv6 are they scoped?

          Show
          Patrick Hunt added a comment - I don't think we can just remove this, see "Textual representation of IPv6 scoped addresses" here: http://download.oracle.com/javase/1,5.0/docs/api/java/net/Inet6Address.html What is the failure you are seeing? Do you have ipv6 address or ipv4 on your loopback interface? If ipv6 are they scoped?
          Hide
          Daniel Gómez Ferro added a comment -

          I added a log printing the bind address with the scope: fe80:0:0:0:0:0:0:1%1
          And this is the address NIOServerCnxnFactory tries to bind to: /fe80:0:0:0:0:0:0:1%0:11221

          If we remove the scope it tries to use a different one and it fails with java.net.BindException: Can't assign requested address

          Show
          Daniel Gómez Ferro added a comment - I added a log printing the bind address with the scope: fe80:0:0:0:0:0:0:1%1 And this is the address NIOServerCnxnFactory tries to bind to: /fe80:0:0:0:0:0:0:1%0:11221 If we remove the scope it tries to use a different one and it fails with java.net.BindException: Can't assign requested address
          Hide
          Daniel Gómez Ferro added a comment -

          From your link I understand the scoped IPV6 address is valid:

          The textual representation of IPv6 addresses as described above can be extended to specify IPv6 scoped addresses.

          The general format for specifying the scope_id is the following:
          IPv6-address%scope_id

          So what's wrong is removing it, no?

          Show
          Daniel Gómez Ferro added a comment - From your link I understand the scoped IPV6 address is valid: The textual representation of IPv6 addresses as described above can be extended to specify IPv6 scoped addresses. The general format for specifying the scope_id is the following: IPv6-address%scope_id So what's wrong is removing it, no?
          Hide
          Patrick Hunt added a comment -

          Odd. I just tried playing with IPV6 only on my lo device, using various scopes and it works for me both with and without this patch. I vaguely remember adding this line because some issue found during testing, but I can't reproduce. I'll go ahead and commit this, we'll see if anyone finds it again or not. Thanks Daniel!

          Show
          Patrick Hunt added a comment - Odd. I just tried playing with IPV6 only on my lo device, using various scopes and it works for me both with and without this patch. I vaguely remember adding this line because some issue found during testing, but I can't reproduce. I'll go ahead and commit this, we'll see if anyone finds it again or not. Thanks Daniel!
          Hide
          Patrick Hunt added a comment -

          committed to trunk/3.5.0, thanks Daniel!

          Show
          Patrick Hunt added a comment - committed to trunk/3.5.0, thanks Daniel!
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #1347 (See https://builds.apache.org/job/ZooKeeper-trunk/1347/)
          ZOOKEEPER-1256. ClientPortBindTest is failing on Mac OS X (Daniel Gómez Ferro via phunt)

          phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189918
          Files :

          • /zookeeper/trunk/CHANGES.txt
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientPortBindTest.java
          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #1347 (See https://builds.apache.org/job/ZooKeeper-trunk/1347/ ) ZOOKEEPER-1256 . ClientPortBindTest is failing on Mac OS X (Daniel Gómez Ferro via phunt) phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189918 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientPortBindTest.java
          Hide
          Flavio Junqueira added a comment -

          We should have committed this one to the 3.4.3 branch. The same patch applies.

          Show
          Flavio Junqueira added a comment - We should have committed this one to the 3.4.3 branch. The same patch applies.

            People

            • Assignee:
              Daniel Gómez Ferro
              Reporter:
              Daniel Gómez Ferro
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development