[ZOOKEEPER-1192] Leader.waitForEpochAck() checks waitingForNewEpoch instead of checking electionFinished

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 3.4.0, 3.5.0
• Component/s: server
• Assignee: Alexander Shraer
• Reporter: Alexander Shraer
• Created: 19/Sep/11 02:00
• Updated: 23/Nov/11 19:22
• Resolved: 05/Nov/11 06:15

Description

A follower/leader should block in Leader.waitForEpochAck() until either electingFollowers contains a quorum and electionFinished=true or until a timeout occurs. A timeout means that a quorum of followers didn't ack the epoch on time, which is an error.

But the check in Leader.waitForEpochAck() is "if (waitingForNewEpoch) throw..." and this will never be triggered, even if the wait statement just timed out, because Leader.getEpochToPropose() completes and sets waitingForNewEpoch to false before Leader.waitForEpochAck() is invoked.

Instead of "if (waitingForNewEpoch) throw" the condition in Leader.waitForEpochAck() should be "if (!electionFinished) throw".
The guarded block introduced in ZK-1191 should be checking !electionFinished.