[ZOOKEEPER-1174] FD leak when network unreachable

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.3.3
• Fix Version/s: 3.3.4, 3.4.0, 3.5.0
• Component/s: java client
• Assignee: Ted Dunning
• Reporter: Ted Dunning
• Created: 08/Sep/11 19:47
• Updated: 23/Nov/11 19:22
• Resolved: 30/Sep/11 23:02

Description

In the socket connection logic there are several errors that result in bad behavior. The basic problem is that a socket is registered with a selector unconditionally when there are nuances that should be dealt with. First, the socket may connect immediately. Secondly, the connect may throw an exception. In either of these two cases, I don't think that the socket should be registered.

I will attach a test case that demonstrates the problem. I have been unable to create a unit test that exhibits the problem because I would have to mock the low level socket libraries to do so. It would still be good to do so if somebody can figure out a good way.

Issue Links

• breaks: ZOOKEEPER-1271 testEarlyLeaderAbandonment failing on solaris - clients not retrying connection
• is related to: ZOOKEEPER-1205 Add a unit test for Kerberos Ticket-Granting Ticket (TGT) renewal