Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.0
    • Fix Version/s: 3.4.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I tried testing out zk on java 7 (not yet officially supported) but I ran into a road block due to the build failing. Patch coming next.

        Activity

        Patrick Hunt created issue -
        Hide
        Patrick Hunt added a comment -

        This patch addresses a new check added to javac in version 7. This is the default in java 6 (default source to target) so should be a relatively low risk change.

        With this patch applied I can compile and run all tests successfully using java7.

        Show
        Patrick Hunt added a comment - This patch addresses a new check added to javac in version 7. This is the default in java 6 (default source to target) so should be a relatively low risk change. With this patch applied I can compile and run all tests successfully using java7.
        Patrick Hunt made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-1171.patch [ 12492796 ]
        Patrick Hunt made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12492796/ZOOKEEPER-1171.patch
        against trunk revision 1164632.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/491//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/491//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/491//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12492796/ZOOKEEPER-1171.patch against trunk revision 1164632. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/491//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/491//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/491//console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        Pat,
        Dont we need to do this for build.xml files in recipes/rest and others?

        Show
        Mahadev konar added a comment - Pat, Dont we need to do this for build.xml files in recipes/rest and others?
        Mahadev konar made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Patrick Hunt added a comment -

        No, the toplevel build.xml is the only file in which we specify an explicit target. As a result the other builds should build fine - although I didn't test that as my main goal here is to get the trunk build working on jdk7 and setup a jenkins job.

        I think this should just go in as-is.

        Show
        Patrick Hunt added a comment - No, the toplevel build.xml is the only file in which we specify an explicit target. As a result the other builds should build fine - although I didn't test that as my main goal here is to get the trunk build working on jdk7 and setup a jenkins job. I think this should just go in as-is.
        Patrick Hunt made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Mahadev konar added a comment -

        Just pushed this. thanks pat!

        Show
        Mahadev konar added a comment - Just pushed this. thanks pat!
        Mahadev konar made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1304 (See https://builds.apache.org/job/ZooKeeper-trunk/1304/)
        ZOOKEEPER-1171. fix build for java 7 (phunt via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170365
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/build.xml
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1304 (See https://builds.apache.org/job/ZooKeeper-trunk/1304/ ) ZOOKEEPER-1171 . fix build for java 7 (phunt via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170365 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/build.xml
        Mahadev konar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        6d 6h 10m 1 Mahadev konar 09/Sep/11 02:52
        Open Open Patch Available Patch Available
        4d 16h 47m 2 Patrick Hunt 13/Sep/11 19:34
        Patch Available Patch Available Resolved Resolved
        3h 16m 1 Mahadev konar 13/Sep/11 22:50
        Resolved Resolved Closed Closed
        70d 21h 31m 1 Mahadev konar 23/Nov/11 19:22

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development