Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.0
    • Component/s: tests
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      in reviewing some tests that weren't passing i notices that the tick time was 2ms rather than the normal 2000ms. i think this is causing tests to fail on some slow/overloaded machines.

      1. ZOOKEEPER-1160.patch
        11 kB
        Benjamin Reed
      2. ZOOKEEPER-1160.patch
        8 kB
        Benjamin Reed

        Activity

        Mahadev konar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1296 (See https://builds.apache.org/job/ZooKeeper-trunk/1296/)
        ZOOKEEPER-1160. test timeouts are too small (breed via phunt)

        phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165378
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLENewEpochTest.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLERestartTest.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLETest.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/LETest.java
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1296 (See https://builds.apache.org/job/ZooKeeper-trunk/1296/ ) ZOOKEEPER-1160 . test timeouts are too small (breed via phunt) phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165378 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLENewEpochTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLERestartTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLETest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/LETest.java
        Patrick Hunt made changes -
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hide
        Patrick Hunt added a comment -

        thanks Ben!

        Show
        Patrick Hunt added a comment - thanks Ben!
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12492952/ZOOKEEPER-1160.patch
        against trunk revision 1164758.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 21 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/499//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/499//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/499//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12492952/ZOOKEEPER-1160.patch against trunk revision 1164758. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 21 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/499//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/499//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/499//console This message is automatically generated.
        Benjamin Reed made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Benjamin Reed made changes -
        Attachment ZOOKEEPER-1160.patch [ 12492951 ]
        Benjamin Reed made changes -
        Attachment ZOOKEEPER-1160.patch [ 12492952 ]
        Benjamin Reed made changes -
        Attachment ZOOKEEPER-1160.patch [ 12492951 ]
        Hide
        Benjamin Reed added a comment -

        rebased patch

        Show
        Benjamin Reed added a comment - rebased patch
        Patrick Hunt made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Patrick Hunt added a comment -

        Ben can you update the patch to apply cleanly?

        Show
        Patrick Hunt added a comment - Ben can you update the patch to apply cleanly?
        Patrick Hunt made changes -
        Assignee Benjamin Reed [ breed ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12491306/ZOOKEEPER-1160.patch
        against trunk revision 1159929.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 24 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/471//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12491306/ZOOKEEPER-1160.patch against trunk revision 1159929. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/471//console This message is automatically generated.
        Benjamin Reed made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Benjamin Reed made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-1160.patch [ 12491306 ]
        Benjamin Reed created issue -

          People

          • Assignee:
            Benjamin Reed
            Reporter:
            Benjamin Reed
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development