Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.4.0
    • Fix Version/s: 3.4.0
    • Component/s: server
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      stat output seems to be missing some end of line:

      echo stat |nc c0309 2181
      Zookeeper version: 3.4.0--1, built on 08/02/2011 22:25 GMT
      Clients:
       /172.29.81.91:33378[0](queued=0,recved=1,sent=0
      Latency min/avg/max: 0/28/252
      Received: 246844
      Sent: 266737
      Outstanding: 0
      Zxid: 0x4000508c2
      Mode: follower
      Node count: 4
      

      Multiple clients end up on the same line (missing newline)

        Activity

        Hide
        Patrick Hunt added a comment -

        this fixes the issue with stat (also issue with cons).

        I ran through most of the commands with both nio and netty and it seems to be working ok with this patch.

        I also added some specific tests to ensure this doesn't happen in future.

        Show
        Patrick Hunt added a comment - this fixes the issue with stat (also issue with cons). I ran through most of the commands with both nio and netty and it seems to be working ok with this patch. I also added some specific tests to ensure this doesn't happen in future.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12489226/ZOOKEEPER-1142.patch
        against trunk revision 1152141.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/436//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/436//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/436//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12489226/ZOOKEEPER-1142.patch against trunk revision 1152141. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/436//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/436//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/436//console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        +1 the patch looks good.

        Show
        Mahadev konar added a comment - +1 the patch looks good.
        Hide
        Mahadev konar added a comment -

        I just pushed this. Thanks Pat!

        Show
        Mahadev konar added a comment - I just pushed this. Thanks Pat!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1260 (See https://builds.apache.org/job/ZooKeeper-trunk/1260/)
        ZOOKEEPER-1142. incorrect stat output (phunt via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156497
        Files :

        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ServerCnxn.java
        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1260 (See https://builds.apache.org/job/ZooKeeper-trunk/1260/ ) ZOOKEEPER-1142 . incorrect stat output (phunt via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156497 Files : /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ServerCnxn.java /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development