Hudson added a comment - 10/Aug/11 02:26 Integrated in ZooKeeper-trunk #1258 (See https://builds.apache.org/job/ZooKeeper-trunk/1258/ ) ZOOKEEPER-1139 . jenkins is reporting two warnings, fix these (phunt via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1152036 Files : /zookeeper/trunk/src/java/main/org/apache/zookeeper/Op.java /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientWatchManager.java

Mahadev konar added a comment - 29/Jul/11 00:23 I just committed this. Thanks pat!

Hadoop QA added a comment - 27/Jul/11 23:15 -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12488036/ZOOKEEPER-1139.patch against trunk revision 1150937. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 26 release audit warnings (more than the trunk's current 24 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/416//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/416//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/416//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/416//console This message is automatically generated.

Patrick Hunt added a comment - 27/Jul/11 22:47 cleanup the warnings