ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1119

zkServer stop command incorrectly reading comment lines in zoo.cfg

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.3
    • Fix Version/s: 3.4.0
    • Component/s: scripts
    • Labels:
      None
    • Environment:

      Ubuntu Linux 10.04, JDK 6

    • Hadoop Flags:
      Reviewed

      Description

      Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):

      # the directory where the snapshot is stored.
      # dataDir=test123/data
      dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
      

      and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:

      gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
      JMX enabled by default
      Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
      Stopping zookeeper ... 
      error: could not find file test123/data
      /export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
      gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 
      

      If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
      error: could not find file test123456/data

      showing that it's incorrectly doing a run-time read of the commented-out lines. (Difficult to completely confirm, but this problem doesn't appear to occur with the start command, only the stop one.)

        Activity

        Hide
        Patrick Hunt added a comment -

        this fixes the problem identified, for all scripts I could find. we were using grep on the config file w/o ignoring commented out lines. This patch only looks for uncommented dataDir (etc...).

        Show
        Patrick Hunt added a comment - this fixes the problem identified, for all scripts I could find. we were using grep on the config file w/o ignoring commented out lines. This patch only looks for uncommented dataDir (etc...).
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12485650/ZOOKEEPER-1119.patch
        against trunk revision 1143688.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/379//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/379//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/379//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12485650/ZOOKEEPER-1119.patch against trunk revision 1143688. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/379//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/379//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/379//console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        Just committed this. Thanks Pat!

        Show
        Mahadev konar added a comment - Just committed this. Thanks Pat!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1255 (See https://builds.apache.org/job/ZooKeeper-trunk/1255/)
        ZOOKEEPER-1119. zkServer stop command incorrectly reading comment lines in zoo.cfg (phunt via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150937
        Files :

        • /zookeeper/trunk/bin/zkCleanup.sh
        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/bin/zkServer.sh
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1255 (See https://builds.apache.org/job/ZooKeeper-trunk/1255/ ) ZOOKEEPER-1119 . zkServer stop command incorrectly reading comment lines in zoo.cfg (phunt via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150937 Files : /zookeeper/trunk/bin/zkCleanup.sh /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/bin/zkServer.sh
        Hide
        Eric Yang added a comment -

        Sync up with trunk

        Show
        Eric Yang added a comment - Sync up with trunk

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Glen Mazza
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development