As stated in the title, org.apache.zookeeper.test.JMXEnv uses System.err.println to output traces. This makes for a lot of noise on the console when you run the tests. It has a logging object already, so it should use that instead.
Patch is very simple. Simply replaces System.err with LOG.info.
I neglected to mention that this only really shows up on hedwig, as zookeeper itself uses ant and ant's junit launcher hijacks System.err into the test log file.
Ivan Kelly
added a comment - Patch is very simple. Simply replaces System.err with LOG.info.
I neglected to mention that this only really shows up on hedwig, as zookeeper itself uses ant and ant's junit launcher hijacks System.err into the test log file.
Hadoop QA
added a comment - +1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12484744/ZOOKEEPER-1111.diff
against trunk revision 1140017.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/359//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/359//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/359//console
This message is automatically generated.
Hadoop QA
added a comment - +1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12484744/ZOOKEEPER-1111.diff
against trunk revision 1144087.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/386//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/386//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/386//console
This message is automatically generated.
Patch is very simple. Simply replaces System.err with LOG.info.
I neglected to mention that this only really shows up on hedwig, as zookeeper itself uses ant and ant's junit launcher hijacks System.err into the test log file.