Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 3.4.0
-
Component/s: None
-
Labels:None
-
Hadoop Flags:Reviewed
Description
As stated in the title, org.apache.zookeeper.test.JMXEnv uses System.err.println to output traces. This makes for a lot of noise on the console when you run the tests. It has a logging object already, so it should use that instead.
Issue Links
- relates to
-
BOOKKEEPER-30
Test are too noisy
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Attachment | ZOOKEEPER-1111.diff [ 12484744 ] |
| Status | Open [ 1 ] | Patch Available [ 10002 ] |
| Fix Version/s | 3.4.0 [ 12314469 ] |
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12484744/ZOOKEEPER-1111.diff
against trunk revision 1140017.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/359//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/359//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/359//console
This message is automatically generated.
| Link |
This issue relates to |
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12484744/ZOOKEEPER-1111.diff
against trunk revision 1144087.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/386//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/386//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/386//console
This message is automatically generated.
Committed to trunk, thanks Ivan!
| Status | Patch Available [ 10002 ] | Resolved [ 5 ] |
| Hadoop Flags | [Reviewed] | |
| Resolution | Fixed [ 1 ] |
Integrated in ZooKeeper-trunk #1249 (See https://builds.apache.org/job/ZooKeeper-trunk/1249/)
ZOOKEEPER-1111. JMXEnv uses System.err instead of logging (Ivan Kelly via phunt)
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148553
Files :
- /zookeeper/trunk/CHANGES.txt
- /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/JMXEnv.java
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Patch is very simple. Simply replaces System.err with LOG.info.
I neglected to mention that this only really shows up on hedwig, as zookeeper itself uses ant and ant's junit launcher hijacks System.err into the test log file.