[ZOOKEEPER-1104] CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: tests
• Hadoop Flags: Reviewed
• Release Note: Contains improvement to original patch (remove unneeded boolean variable).
• Assignee: Eugene Joseph Koontz
• Reporter: sreekanth
• Created: 22/Jun/11 18:21
• Updated: 23/Nov/11 19:22
• Resolved: 15/Aug/11 00:54

Description

Patrick Hunt writes:

"Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
of sleep in testSessionMove in the same class for a better way to do
this. I had gone through all the tests a while back, replacing all the
"sleep" with something like this testSessionMove pattern (retry
with a max limit that's very long). During reviews we should look for
anti-patterns like this and address them before commit."

So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.

Issue Links

• is a clone of: ZOOKEEPER-1103 In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.