ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1086

zookeeper test jar has non mavenised dependency.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The zookeeper test jar, (zookeeper-<version>-test.jar) depends on accessive.jar which is not available in maven. This is problematic for projects using the test jar (i.e. hedwig).

      1. ZOOKEEPER-1086.diff
        0.6 kB
        Ivan Kelly
      2. ZOOKEEPER-1086.diff
        16 kB
        Ivan Kelly

        Issue Links

          Activity

          Ivan Kelly created issue -
          Hide
          Ivan Kelly added a comment -

          Simple solution is to ship accessive.jar contents and license inside zookeeper test jar.

          Show
          Ivan Kelly added a comment - Simple solution is to ship accessive.jar contents and license inside zookeeper test jar.
          Ivan Kelly made changes -
          Field Original Value New Value
          Attachment ZOOKEEPER-1086.diff [ 12481058 ]
          Ivan Kelly made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Fix Version/s 3.4.0 [ 12314469 ]
          Ivan Kelly made changes -
          Link This issue blocks BOOKKEEPER-20 [ BOOKKEEPER-20 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12481058/ZOOKEEPER-1086.diff
          against trunk revision 1125581.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/303//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/303//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/303//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481058/ZOOKEEPER-1086.diff against trunk revision 1125581. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/303//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/303//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/303//console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          Perhaps we should just drop accessive? Questionable idea (mine) anyway, we could refactor the code instead. I ran into similar issues when creating maven support for building ZK itself. From what I can tell on the accessive site the author has not intention of publishing on a maven repo...

          Show
          Patrick Hunt added a comment - Perhaps we should just drop accessive? Questionable idea (mine) anyway, we could refactor the code instead. I ran into similar issues when creating maven support for building ZK itself. From what I can tell on the accessive site the author has not intention of publishing on a maven repo...
          Hide
          Ivan Kelly added a comment -

          This is also a possibility. I've attached a patch that removes accessive.jar. You guys can vote on which approach you prefer.

          Show
          Ivan Kelly added a comment - This is also a possibility. I've attached a patch that removes accessive.jar. You guys can vote on which approach you prefer.
          Ivan Kelly made changes -
          Attachment ZOOKEEPER-1086.diff [ 12481118 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12481118/ZOOKEEPER-1086.diff
          against trunk revision 1125581.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/304//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/304//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/304//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481118/ZOOKEEPER-1086.diff against trunk revision 1125581. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/304//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/304//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/304//console This message is automatically generated.
          Hide
          Benjamin Reed added a comment -

          +1 looks good.

          Show
          Benjamin Reed added a comment - +1 looks good.
          Benjamin Reed made changes -
          Hadoop Flags [Reviewed]
          Hide
          Michi Mutsuzaki added a comment -

          Checked into trunk.

          --Michi

          Show
          Michi Mutsuzaki added a comment - Checked into trunk. --Michi
          Michi Mutsuzaki made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #1215 (See https://builds.apache.org/job/ZooKeeper-trunk/1215/)

          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #1215 (See https://builds.apache.org/job/ZooKeeper-trunk/1215/ )
          Hide
          Thomas Koch added a comment -

          The accessive.jar is still in SVN under src/java/libtest/accessive.jar. Please remove it, if it's not needed anymore.
          I've also contacted the author of accessive and mavenized the project with him. It should be available soon, if you still need it.

          Show
          Thomas Koch added a comment - The accessive.jar is still in SVN under src/java/libtest/accessive.jar. Please remove it, if it's not needed anymore. I've also contacted the author of accessive and mavenized the project with him. It should be available soon, if you still need it.
          Thomas Koch made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Mahadev konar added a comment -

          Just removed the jars. Thanks Thomas for pointing out.

          Show
          Mahadev konar added a comment - Just removed the jars. Thanks Thomas for pointing out.
          Mahadev konar made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #1337 (See https://builds.apache.org/job/ZooKeeper-trunk/1337/)
          ZOOKEEPER-1086. zookeeper test jar has non mavenised dependency.

          mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185994
          Files :

          • /zookeeper/trunk/src/java/libtest/accessive.jar
          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #1337 (See https://builds.apache.org/job/ZooKeeper-trunk/1337/ ) ZOOKEEPER-1086 . zookeeper test jar has non mavenised dependency. mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185994 Files : /zookeeper/trunk/src/java/libtest/accessive.jar
          Mahadev konar made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          7m 21s 1 Ivan Kelly 01/Jun/11 11:59
          Patch Available Patch Available Resolved Resolved
          12d 9h 11m 1 Michi Mutsuzaki 13/Jun/11 21:11
          Resolved Resolved Reopened Reopened
          98d 13h 4m 1 Thomas Koch 20/Sep/11 10:15
          Reopened Reopened Resolved Resolved
          28d 21h 40m 1 Mahadev konar 19/Oct/11 07:56
          Resolved Resolved Closed Closed
          35d 12h 25m 1 Mahadev konar 23/Nov/11 19:22

            People

            • Assignee:
              Ivan Kelly
              Reporter:
              Ivan Kelly
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development