ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1074

zkServer.sh is missing nohup/sleep, which are necessary for remote invocation

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.3, 3.4.0
    • Fix Version/s: 3.4.0
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      zkServer.sh is missing nohup and "sleep 1" when starting the background daemon.

      This is fine normally, however when running the server remotely via ssh this causes the process to not run successfully (it starts but immediately exits).

      I'll be submitting a patch for this shortly.

        Activity

        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1226 (See https://builds.apache.org/job/ZooKeeper-trunk/1226/)
        ZOOKEEPER-1074. zkServer.sh is missing nohup/sleep, which are necessary for remote invocation. (phunt via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1140017
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/bin/zkServer.sh
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1226 (See https://builds.apache.org/job/ZooKeeper-trunk/1226/ ) ZOOKEEPER-1074 . zkServer.sh is missing nohup/sleep, which are necessary for remote invocation. (phunt via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1140017 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/bin/zkServer.sh
        Hide
        Mahadev konar added a comment -

        +1. the patch looks good. I just pushed this to trunk. Thanks Pat!

        Show
        Mahadev konar added a comment - +1. the patch looks good. I just pushed this to trunk. Thanks Pat!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12480443/ZOOKEEPER-1074.patch
        against trunk revision 1125581.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/286//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/286//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/286//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12480443/ZOOKEEPER-1074.patch against trunk revision 1125581. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/286//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/286//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/286//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        Added nohup/sleep.

        Note: this is very similar to what bin/hadoop does.

        Show
        Patrick Hunt added a comment - Added nohup/sleep. Note: this is very similar to what bin/hadoop does.

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development