Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Committed revision 1125544

      Description

      fix Request getData to print that instead of getDate

      1. ZOOKEEPER-1058
        0.5 kB
        Camille Fournier

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478113/ZOOKEEPER-1058
        against trunk revision 1099267.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/243//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/243//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/243//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478113/ZOOKEEPER-1058 against trunk revision 1099267. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/243//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/243//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/243//console This message is automatically generated.
        Hide
        Benjamin Reed added a comment -

        +1 looks great camille do you want to commit it?

        Show
        Benjamin Reed added a comment - +1 looks great camille do you want to commit it?
        Hide
        Camille Fournier added a comment -

        Still waiting on my account, not sure when it is coming, I can check it in when that is set up or you can push it now.

        Show
        Camille Fournier added a comment - Still waiting on my account, not sure when it is coming, I can check it in when that is set up or you can push it now.
        Hide
        Benjamin Reed added a comment -

        fortunately, this patch isn't likely to go stale it will be good practice for you.

        Show
        Benjamin Reed added a comment - fortunately, this patch isn't likely to go stale it will be good practice for you.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1189 (See https://builds.apache.org/hudson/job/ZooKeeper-trunk/1189/)
        ZOOKEEPER-1058: fix typo in opToString for getData

        camille : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125544
        Files :

        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/Request.java
        • /zookeeper/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1189 (See https://builds.apache.org/hudson/job/ZooKeeper-trunk/1189/ ) ZOOKEEPER-1058 : fix typo in opToString for getData camille : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125544 Files : /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/Request.java /zookeeper/trunk/CHANGES.txt

          People

          • Assignee:
            Camille Fournier
            Reporter:
            Camille Fournier
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development