ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1052

Findbugs warning in QuorumPeer.ResponderThread.run()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.2
    • Fix Version/s: 3.4.0
    • Component/s: None
    • Labels:
      None

      Description

      REC 	Exception is caught when Exception is not thrown in org.apache.zookeeper.server.quorum.QuorumPeer$ResponderThread.run()
      
      1. ZOOKEEPER-1052.patch
        0.9 kB
        Flavio Junqueira

        Activity

        Hide
        Flavio Junqueira added a comment -

        This patch splits the previous Exception into IOException and RuntimeException. We need to catch IOException, since it is thrown inside the block, and we also want to catch RuntimeExceptions so that we can warn an operator about the responder thread dying. Findbugs does not like having a block catching exception.

        Show
        Flavio Junqueira added a comment - This patch splits the previous Exception into IOException and RuntimeException. We need to catch IOException, since it is thrown inside the block, and we also want to catch RuntimeExceptions so that we can warn an operator about the responder thread dying. Findbugs does not like having a block catching exception.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12477244/ZOOKEEPER-1052.patch
        against trunk revision 1091841.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/231//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/231//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/231//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12477244/ZOOKEEPER-1052.patch against trunk revision 1091841. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/231//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/231//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/231//console This message is automatically generated.
        Hide
        Michi Mutsuzaki added a comment -

        +1

        The patch looks good. Would it be ok if I go ahead and check this in, or should I wait for one more person to review it?

        Thanks!
        --Michi

        Show
        Michi Mutsuzaki added a comment - +1 The patch looks good. Would it be ok if I go ahead and check this in, or should I wait for one more person to review it? Thanks! --Michi
        Hide
        Michi Mutsuzaki added a comment -

        Checked into trunk.

        Show
        Michi Mutsuzaki added a comment - Checked into trunk.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1172 (See https://builds.apache.org/hudson/job/ZooKeeper-trunk/1172/)
        ZOOKEEPER-1052. Findbugs warning in QuorumPeer.ResponderThread.run() (fpj via michim)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1172 (See https://builds.apache.org/hudson/job/ZooKeeper-trunk/1172/ ) ZOOKEEPER-1052 . Findbugs warning in QuorumPeer.ResponderThread.run() (fpj via michim)

          People

          • Assignee:
            Flavio Junqueira
            Reporter:
            Flavio Junqueira
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development